Skip to content

fix build issue in nix-shell --pure#190

Merged
ti-srebot merged 4 commits intotikv:masterfrom
iosmanthus:refine-development-env
Jun 9, 2021
Merged

fix build issue in nix-shell --pure#190
ti-srebot merged 4 commits intotikv:masterfrom
iosmanthus:refine-development-env

Conversation

@iosmanthus
Copy link
Copy Markdown
Member

@iosmanthus iosmanthus commented Jun 8, 2021

What problem does this PR solve?

Fix missing environment variables in nix-shell --pure.

Check List

Tests

  • Manual test (add detailed scripts or steps below)
nix-shell --pure shell.nix
mvn clean install -Dmaven.test.skip=true

Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
@iosmanthus iosmanthus requested a review from marsishandsome June 8, 2021 11:41
Copy link
Copy Markdown
Collaborator

@marsishandsome marsishandsome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marsishandsome
Copy link
Copy Markdown
Collaborator

/merge

@ti-srebot
Copy link
Copy Markdown
Collaborator

/run-all-tests

@ti-srebot ti-srebot merged commit 3be4daf into tikv:master Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants