[Feature Request] Add podDisruptionBudget in API server#2940
Merged
tmjd merged 4 commits intoApr 1, 2024
Merged
Conversation
caseydavenport
requested changes
Oct 26, 2023
caseydavenport
left a comment
Member
There was a problem hiding this comment.
@MuhtasimTanmoy thanks for the PR! I've left a couple of small comments on it.
caseydavenport
approved these changes
Oct 27, 2023
Member
|
/sem-approve |
Member
|
@MuhtasimTanmoy looks like Here's an example failure: You should be able to run these locally with |
tmjd
reviewed
Mar 29, 2024
tmjd
left a comment
Member
There was a problem hiding this comment.
I've pushed a commit to this branch, I found one bit I think needed changing (I've put a comment there) and I've fixed up the unit tests, they passed for me locally.
Member
|
/sem-approve |
caseydavenport
approved these changes
Apr 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #2886
This PR adds
podDisruptionBudgetin the API Server and affects thecalico-apiservercomponent.Testing
For testing this feature :
kubectl create -f ./config/samples/operator_v1_apiserver.yamlkubectl -n calico-system get pdbpodDisruptionBudgetforcalico-apiservercomponent.For PR author
make gen-filesmake gen-versionsFor PR reviewers
A note for code reviewers - all pull requests must have the following:
kind/bugif this is a bugfix.kind/enhancementif this is a new feature.enterpriseif this PR applies to Calico Enterprise only.