Skip to content

refactor: remove CycloneDDS source bundling by leveraging public APIs#328

Open
xygyo77 wants to merge 6 commits into
tier4:mainfrom
xygyo77:refactor/unbundle-cyclonedds
Open

refactor: remove CycloneDDS source bundling by leveraging public APIs#328
xygyo77 wants to merge 6 commits into
tier4:mainfrom
xygyo77:refactor/unbundle-cyclonedds

Conversation

@xygyo77

@xygyo77 xygyo77 commented May 27, 2026

Copy link
Copy Markdown
Contributor

Description

This PR refactors the CycloneDDS hooking mechanism to fully eliminate source bundling. By leveraging upstream public APIs, it ensures a clean build environment for ROS 2 Jazzy and newer, while maintaining robust tracing capabilities for Humble and Iron.

Transition to Public APIs: Removed the dependency on private dds_write_impl and transitioned to hooking public dds_write, dds_writecdr and dds_write_ts.

  • Jazzy: Confirmed that tracing and visualization work perfectly for both regular and generic communications.

  • Humble: Confirmed successful visualization and accurate latency calculation across all standard communication paths.

  • This PR must be merged and verified in conjunction with the corresponding caret PR (https://github.com/tier4/caret/pull/234).

Related links

https://tier4.atlassian.net/browse/SYSPERF-126

Notes for reviewers

Pre-review checklist for the PR author

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR has been properly tested.
  • The PR has been reviewed.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

xygyo77 added 3 commits May 22, 2026 00:41
… custom CMake modifications

Signed-off-by: ISP akm <akm@isp.co.jp>
…ook logic.

Signed-off-by: ISP akm <akm@isp.co.jp>
…tamp traces are collected at all times. Additionally, the original dds_time is used.

Signed-off-by: ISP akm <akm@isp.co.jp>
@xygyo77 xygyo77 requested a review from miyakoshi-dev May 27, 2026 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant