refactor: remove CycloneDDS source bundling by leveraging public APIs#328
Open
xygyo77 wants to merge 6 commits into
Open
refactor: remove CycloneDDS source bundling by leveraging public APIs#328xygyo77 wants to merge 6 commits into
xygyo77 wants to merge 6 commits into
Conversation
… custom CMake modifications Signed-off-by: ISP akm <akm@isp.co.jp>
…ook logic. Signed-off-by: ISP akm <akm@isp.co.jp>
…tamp traces are collected at all times. Additionally, the original dds_time is used. Signed-off-by: ISP akm <akm@isp.co.jp>
Signed-off-by: ISP akm <akm@isp.co.jp>
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the CycloneDDS hooking mechanism to fully eliminate source bundling. By leveraging upstream public APIs, it ensures a clean build environment for ROS 2 Jazzy and newer, while maintaining robust tracing capabilities for Humble and Iron.
Transition to Public APIs: Removed the dependency on private
dds_write_impland transitioned to hooking publicdds_write,dds_writecdranddds_write_ts.Jazzy: Confirmed that tracing and visualization work perfectly for both regular and generic communications.
Humble: Confirmed successful visualization and accurate latency calculation across all standard communication paths.
This PR must be merged and verified in conjunction with the corresponding
caretPR (https://github.com/tier4/caret/pull/234).Related links
https://tier4.atlassian.net/browse/SYSPERF-126
Notes for reviewers
Pre-review checklist for the PR author
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.