Repository navigation
chore(deps): update dependency imposter to 0.2.10 - #7021
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to No actionable issue is established for this dependency update; it is mergeable after normal checks. Pre-merge checks |
|
|
c1fc146 to
da2a512
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: da2a512b27
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <PackageVersion Include="Microsoft.Testing.Platform" Version="2.5.1" /> | ||
| <PackageVersion Include="Microsoft.Testing.Platform.MSBuild" Version="2.5.1" /> | ||
| <PackageVersion Include="Imposter" Version="0.2.8"/> | ||
| <PackageVersion Include="Imposter" Version="0.2.10"/> |
There was a problem hiding this comment.
Pin Imposter to the reviewed 0.2.9 release
The commit title, dependency table, and included release notes all describe reviewing an upgrade from 0.2.8 to 0.2.9, but this line actually selects 0.2.10. As a result, consumers build against a different, otherwise unreviewed release; either pin this to 0.2.9 or update the change metadata and validation to cover 0.2.10.
Useful? React with 👍 / 👎.
This PR contains the following updates:
0.2.8→0.2.10Release Notes
themidnightgospel/Imposter (Imposter)
v0.2.10: Ref struct indexer keysCompare Source
Features
ref structtype (#297, part of #201). A key of a ref struct type, passed by value, no longer reports IMP009. An imposter can't keep or match a ref struct key, so it passes the key through:imposter[Arg<int>.Any()].Getter().Returns((row, locator) => row + locator.Offset).Returns,CallbackandThrows, and the base implementation, get the key.imposter.Indexer()orimposter.Indexer_1(). Its interface's setup view declares the same method.Still IMP009 (see Limitations):
in;inorref readonlykey and a base getter;v0.2.9: Custom ref struct members, and generated name clashesCompare Source
Features
Members with a custom
ref structtype, part of #201. These no longer report IMP009. An imposter can't keep or match a ref struct, so it only passes one between the caller and your delegates:Returns,CallbackandThrows, and the base implementation, get the argument, by reference forrefandout.Read_1.Returnstakes only a delegate, as inReturns(size => new Slot(size)).default.Raisepasses it on to the callbacks and the handlers, andRaisedmatches the other arguments.Returnstakes only a delegate.Setter()takes no criteria, andCalledcounts every set.default.Returnstakes only the delegate that gets the keys.Calledleave the value out.default.Still IMP009 (see Limitations):
inorref readonlykey and a base getter;Fixes
Generated types named like another member (#293, closes #289). The imposter declares types named after each member, such as
ICurrentPropertyBuilderorGetDelegate. Two cases made the imposter fail with CS0102:FooandFooCallback.The member whose types clash now names them after another unique name. Its setup keeps its name.
Event and indexer builder fields named like another member (#295, closes #294). A property named
_Changednext to an eventChanged, or_IndexerIndexernext to an indexer, failed with CS0102. Those fields now avoid the other members' names, as a property's already did.Configuration
📅 Schedule: (UTC)
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate CLI.