Skip to content

Suppress HTML reports for nested test runs - #6620

Merged
thomhurst merged 1 commit into
mainfrom
agent/reduce-ci-html-report-noise
Aug 17, 2026
Merged

Suppress HTML reports for nested test runs#6620
thomhurst merged 1 commit into
mainfrom
agent/reduce-ci-html-report-noise

Conversation

@thomhurst

Copy link
Copy Markdown
Owner

Summary

  • disable HTML reporting for short-lived child test applications launched by TUnit.Engine.Tests
  • disable HTML reporting for TUnit.TestProject RPC host sessions
  • disable HTML reporting for the two-test Playwright template smoke run
  • preserve reports for the outer, top-level test suites

Why

A representative full .NET workflow produced 144 HTML artifacts. Of those, 54 came from RPC child hosts, 6 from nested F#/VB engine-test runs, and 3 from the Playwright template smoke project. These implementation-detail reports add artifact noise without improving suite-level diagnostics.

With the same matrix and workload, the expected HTML artifact count is reduced from 144 to 81.

Validation

  • dotnet build tests/TUnit.Engine.Tests/TUnit.Engine.Tests.csproj -c Release -f net10.0 --no-restore
  • focused VB engine test passed; outer report remained and no child report was produced
  • dotnet build tests/TUnit.RpcTests/TUnit.RpcTests.csproj -c Release -f net10.0
  • focused RPC test passed for net8.0 and net10.0; outer report remained and no child reports were produced
  • dotnet build tools/TUnit.Pipeline/TUnit.Pipeline.csproj -c Release -f net10.0
  • git diff --check

The focused F# engine test was also attempted locally. Report suppression worked, but the test itself hit the existing local .NET 11 preview / FSharp.Core 11.0.0.0 resolution mismatch.

@coderabbitai

coderabbitai Bot commented Aug 16, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@thomhurst, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 40 minutes

Limit details: You’ve used all 3 included reviews currently available under your plan.

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 8f3880dd-772d-4248-a660-c904e1b31aca

📥 Commits

Reviewing files that changed from the base of the PR and between 501a246 and 3b7c5fe.

📒 Files selected for processing (8)
  • tests/TUnit.Engine.Tests/EnvironmentVariables.cs
  • tests/TUnit.Engine.Tests/ExternalCancellationTests.cs
  • tests/TUnit.Engine.Tests/FSharp.cs
  • tests/TUnit.Engine.Tests/InvokableTestBase.cs
  • tests/TUnit.Engine.Tests/ListTestsFilterTests.cs
  • tests/TUnit.Engine.Tests/VB.cs
  • tests/TUnit.RpcTests/TestHostSession.cs
  • tools/TUnit.Pipeline/Modules/RunPlaywrightTestsModule.cs

Comment @coderabbitai help to get the list of available commands.

@greptile-apps

greptile-apps Bot commented Aug 16, 2026

Copy link
Copy Markdown

Greptile Summary

The PR suppresses redundant HTML artifacts from nested test processes while preserving reports for their outer suites.

  • Centralizes the child-process reporter-disable environment variable for engine tests.
  • Applies suppression to F#, VB, cancellation, list-filter, and shared engine-test child runs.
  • Disables HTML reporting for RPC child hosts and the Playwright template smoke run.

Confidence Score: 5/5

The PR appears safe to merge, with no actionable defects identified in the nested-report suppression paths.

The configured value matches the HTML reporter's supported truthy values, the child launch paths propagate environment variables, and the changes leave outer-suite reporting untouched.

Important Files Changed

Filename Overview
tests/TUnit.Engine.Tests/EnvironmentVariables.cs Adds a shared helper producing the correctly named and formatted HTML-reporter suppression variable.
tests/TUnit.Engine.Tests/InvokableTestBase.cs Reuses the shared suppression helper while preserving per-run environment-variable overrides.
tests/TUnit.RpcTests/TestHostSession.cs Disables HTML reporting for nested RPC server hosts without changing their RPC setup or lifecycle.
tools/TUnit.Pipeline/Modules/RunPlaywrightTestsModule.cs Adds HTML-report suppression alongside the existing GitHub-reporter suppression for the Playwright smoke run.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  Outer["Top-level test suites"] --> EngineChildren["Engine-test child applications"]
  Outer --> RpcChildren["RPC server child hosts"]
  Outer --> PlaywrightChild["Playwright template smoke run"]
  Outer --> OuterReport["Preserved outer HTML reports"]
  EngineChildren --> Disabled1["HTML reporter disabled"]
  RpcChildren --> Disabled2["HTML reporter disabled"]
  PlaywrightChild --> Disabled3["HTML reporter disabled"]
Loading

Reviews (1): Last reviewed commit: "Suppress HTML reports for nested test ru..." | Re-trigger Greptile

@claude

claude Bot commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

Notes:

  • The new EnvironmentVariables.DisableHtmlReporterForChildProcess() helper is used consistently across TUnit.Engine.Tests call sites (ExternalCancellationTests, FSharp, VB, ListTestsFilterTests, InvokableTestBase).
  • TUnit.RpcTests/TestHostSession.cs and tools/TUnit.Pipeline/Modules/RunPlaywrightTestsModule.cs inline the same TUNIT_DISABLE_HTML_REPORTER dictionary entry rather than reusing the helper — this is expected since neither project references TUnit.Engine.Tests, and the value matches EnvironmentConstants.DisableHtmlReporter used by the engine.
  • InvokableTestBase.BuildEnvironmentVariables correctly layers runOptions.EnvironmentVariables on top of the new default, preserving prior override behavior.

@thomhurst
thomhurst merged commit 1589d05 into main Aug 17, 2026
14 checks passed
@thomhurst
thomhurst deleted the agent/reduce-ci-html-report-noise branch August 17, 2026 13:12
This was referenced Aug 18, 2026
This was referenced Aug 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant