Suppress HTML reports for nested test runs - #6620
Conversation
|
Warning Review limit reached
Next review available in: 40 minutes Limit details: You’ve used all 3 included reviews currently available under your plan. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (8)
Comment |
Greptile SummaryThe PR suppresses redundant HTML artifacts from nested test processes while preserving reports for their outer suites.
Confidence Score: 5/5The PR appears safe to merge, with no actionable defects identified in the nested-report suppression paths. The configured value matches the HTML reporter's supported truthy values, the child launch paths propagate environment variables, and the changes leave outer-suite reporting untouched.
|
| Filename | Overview |
|---|---|
| tests/TUnit.Engine.Tests/EnvironmentVariables.cs | Adds a shared helper producing the correctly named and formatted HTML-reporter suppression variable. |
| tests/TUnit.Engine.Tests/InvokableTestBase.cs | Reuses the shared suppression helper while preserving per-run environment-variable overrides. |
| tests/TUnit.RpcTests/TestHostSession.cs | Disables HTML reporting for nested RPC server hosts without changing their RPC setup or lifecycle. |
| tools/TUnit.Pipeline/Modules/RunPlaywrightTestsModule.cs | Adds HTML-report suppression alongside the existing GitHub-reporter suppression for the Playwright smoke run. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
Outer["Top-level test suites"] --> EngineChildren["Engine-test child applications"]
Outer --> RpcChildren["RPC server child hosts"]
Outer --> PlaywrightChild["Playwright template smoke run"]
Outer --> OuterReport["Preserved outer HTML reports"]
EngineChildren --> Disabled1["HTML reporter disabled"]
RpcChildren --> Disabled2["HTML reporter disabled"]
PlaywrightChild --> Disabled3["HTML reporter disabled"]
Reviews (1): Last reviewed commit: "Suppress HTML reports for nested test ru..." | Re-trigger Greptile
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. Notes:
|
Summary
TUnit.Engine.TestsTUnit.TestProjectRPC host sessionsWhy
A representative full .NET workflow produced 144 HTML artifacts. Of those, 54 came from RPC child hosts, 6 from nested F#/VB engine-test runs, and 3 from the Playwright template smoke project. These implementation-detail reports add artifact noise without improving suite-level diagnostics.
With the same matrix and workload, the expected HTML artifact count is reduced from 144 to 81.
Validation
dotnet build tests/TUnit.Engine.Tests/TUnit.Engine.Tests.csproj -c Release -f net10.0 --no-restoredotnet build tests/TUnit.RpcTests/TUnit.RpcTests.csproj -c Release -f net10.0dotnet build tools/TUnit.Pipeline/TUnit.Pipeline.csproj -c Release -f net10.0git diff --checkThe focused F# engine test was also attempted locally. Report suppression worked, but the test itself hit the existing local .NET 11 preview / FSharp.Core 11.0.0.0 resolution mismatch.