Skip to content

fix: stop doubling backslashes in source-gen emitted FilePath (breaks HTML report source links) #6193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomhurst merged 1 commit into from
Jun 8, 2026
Merged

fix: stop doubling backslashes in source-gen emitted FilePath (breaks HTML report source links) #6193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion TUnit.Core.SourceGenerator.Tests/AbstractTests.Concrete1.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ internal static class TUnit_TestProject_AbstractTests_ConcreteClass1_AssertClass
{
MethodName = "AssertClassName",
FullyQualifiedName = "TUnit.TestProject.AbstractTests.ConcreteClass1.AssertClassName",
FilePath = @"",
FilePath = "",
LineNumber = 6,
Categories = global::System.Array.Empty<string>(),
Properties = global::System.Array.Empty<string>(),
Expand Down
6 changes: 3 additions & 3 deletions TUnit.Core.SourceGenerator.Tests/AbstractTests.Concrete2.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ internal static class TUnit_TestProject_AbstractTests_ConcreteClass2__TestSource
{
MethodName = "SecondTest",
FullyQualifiedName = "TUnit.TestProject.AbstractTests.ConcreteClass2.SecondTest",
FilePath = @"",
FilePath = "",
LineNumber = 11,
Categories = global::System.Array.Empty<string>(),
Properties = global::System.Array.Empty<string>(),
Expand Down Expand Up @@ -143,7 +143,7 @@ internal static class TUnit_TestProject_AbstractTests_ConcreteClass2_AssertClass
{
MethodName = "AssertClassName",
FullyQualifiedName = "TUnit.TestProject.AbstractTests.ConcreteClass2.AssertClassName",
FilePath = @"",
FilePath = "",
LineNumber = 6,
Categories = global::System.Array.Empty<string>(),
Properties = global::System.Array.Empty<string>(),
Expand Down Expand Up @@ -218,7 +218,7 @@ internal static class TUnit_TestProject_AbstractTests_ConcreteClass1_AssertClass
{
MethodName = "AssertClassName",
FullyQualifiedName = "TUnit.TestProject.AbstractTests.ConcreteClass1.AssertClassName",
FilePath = @"",
FilePath = "",
LineNumber = 6,
Categories = global::System.Array.Empty<string>(),
Properties = global::System.Array.Empty<string>(),
Expand Down
4 changes: 2 additions & 2 deletions TUnit.Core.SourceGenerator.Tests/AfterAllTests.Test.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ internal static class TUnit_TestProject_AfterTests_CleanupTests__TestSource
{
MethodName = "Test1",
FullyQualifiedName = "TUnit.TestProject.AfterTests.CleanupTests.Test1",
FilePath = @"",
FilePath = "",
LineNumber = 98,
Categories = global::System.Array.Empty<string>(),
Properties = global::System.Array.Empty<string>(),
Expand All @@ -94,7 +94,7 @@ internal static class TUnit_TestProject_AfterTests_CleanupTests__TestSource
{
MethodName = "Test2",
FullyQualifiedName = "TUnit.TestProject.AfterTests.CleanupTests.Test2",
FilePath = @"",
FilePath = "",
LineNumber = 104,
Categories = global::System.Array.Empty<string>(),
Properties = global::System.Array.Empty<string>(),
Expand Down
4 changes: 2 additions & 2 deletions TUnit.Core.SourceGenerator.Tests/AfterTests.Test.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ internal static class TUnit_TestProject_AfterTests_CleanupTests__TestSource
{
MethodName = "Test1",
FullyQualifiedName = "TUnit.TestProject.AfterTests.CleanupTests.Test1",
FilePath = @"",
FilePath = "",
LineNumber = 98,
Categories = global::System.Array.Empty<string>(),
Properties = global::System.Array.Empty<string>(),
Expand All @@ -94,7 +94,7 @@ internal static class TUnit_TestProject_AfterTests_CleanupTests__TestSource
{
MethodName = "Test2",
FullyQualifiedName = "TUnit.TestProject.AfterTests.CleanupTests.Test2",
FilePath = @"",
FilePath = "",
LineNumber = 104,
Categories = global::System.Array.Empty<string>(),
Properties = global::System.Array.Empty<string>(),
Expand Down
18 changes: 9 additions & 9 deletions TUnit.Core.SourceGenerator.Tests/ArgsAsArrayTests.Test.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -504,7 +504,7 @@ global::TUnit.Core.ParameterMetadataFactory.Create(typeof(string[]), "names", ne
{
MethodName = "Params",
FullyQualifiedName = "TUnit.TestProject.ArgsAsArrayTests.Params",
FilePath = @"",
FilePath = "",
LineNumber = 5,
Categories = global::System.Array.Empty<string>(),
Properties = global::System.Array.Empty<string>(),
Expand All @@ -526,7 +526,7 @@ global::TUnit.Core.ParameterMetadataFactory.Create(typeof(string[]), "names", ne
{
MethodName = "ParamsEnumerable",
FullyQualifiedName = "TUnit.TestProject.ArgsAsArrayTests.ParamsEnumerable",
FilePath = @"",
FilePath = "",
LineNumber = 15,
Categories = global::System.Array.Empty<string>(),
Properties = global::System.Array.Empty<string>(),
Expand All @@ -548,7 +548,7 @@ global::TUnit.Core.ParameterMetadataFactory.Create(typeof(string[]), "names", ne
{
MethodName = "Following_Non_Params",
FullyQualifiedName = "TUnit.TestProject.ArgsAsArrayTests.Following_Non_Params",
FilePath = @"",
FilePath = "",
LineNumber = 25,
Categories = global::System.Array.Empty<string>(),
Properties = global::System.Array.Empty<string>(),
Expand All @@ -570,7 +570,7 @@ global::TUnit.Core.ParameterMetadataFactory.Create(typeof(string[]), "names", ne
{
MethodName = "NonParamsStringArray",
FullyQualifiedName = "TUnit.TestProject.ArgsAsArrayTests.NonParamsStringArray",
FilePath = @"",
FilePath = "",
LineNumber = 38,
Categories = global::System.Array.Empty<string>(),
Properties = global::System.Array.Empty<string>(),
Expand All @@ -593,7 +593,7 @@ global::TUnit.Core.ParameterMetadataFactory.Create(typeof(string[]), "names", ne
{
MethodName = "NonParamsStringArray_SingleValue",
FullyQualifiedName = "TUnit.TestProject.ArgsAsArrayTests.NonParamsStringArray_SingleValue",
FilePath = @"",
FilePath = "",
LineNumber = 47,
Categories = global::System.Array.Empty<string>(),
Properties = global::System.Array.Empty<string>(),
Expand All @@ -615,7 +615,7 @@ global::TUnit.Core.ParameterMetadataFactory.Create(typeof(string[]), "names", ne
{
MethodName = "NonParamsStringArray_MultipleValues",
FullyQualifiedName = "TUnit.TestProject.ArgsAsArrayTests.NonParamsStringArray_MultipleValues",
FilePath = @"",
FilePath = "",
LineNumber = 54,
Categories = global::System.Array.Empty<string>(),
Properties = global::System.Array.Empty<string>(),
Expand All @@ -637,7 +637,7 @@ global::TUnit.Core.ParameterMetadataFactory.Create(typeof(string[]), "names", ne
{
MethodName = "NonParamsIntArray",
FullyQualifiedName = "TUnit.TestProject.ArgsAsArrayTests.NonParamsIntArray",
FilePath = @"",
FilePath = "",
LineNumber = 61,
Categories = global::System.Array.Empty<string>(),
Properties = global::System.Array.Empty<string>(),
Expand All @@ -659,7 +659,7 @@ global::TUnit.Core.ParameterMetadataFactory.Create(typeof(string[]), "names", ne
{
MethodName = "GenericStringArray",
FullyQualifiedName = "TUnit.TestProject.ArgsAsArrayTests.GenericStringArray",
FilePath = @"",
FilePath = "",
LineNumber = 69,
Categories = global::System.Array.Empty<string>(),
Properties = global::System.Array.Empty<string>(),
Expand All @@ -681,7 +681,7 @@ global::TUnit.Core.ParameterMetadataFactory.Create(typeof(string[]), "names", ne
{
MethodName = "NonParamsStringArray_BeyondStaticCaseCap",
FullyQualifiedName = "TUnit.TestProject.ArgsAsArrayTests.NonParamsStringArray_BeyondStaticCaseCap",
FilePath = @"",
FilePath = "",
LineNumber = 78,
Categories = global::System.Array.Empty<string>(),
Properties = global::System.Array.Empty<string>(),
Expand Down
4 changes: 2 additions & 2 deletions TUnit.Core.SourceGenerator.Tests/ArgumentWithImplicitConverterTests.Test.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ global::TUnit.Core.ParameterMetadataFactory.Create(typeof(global::TUnit.TestProj
{
MethodName = "Explicit",
FullyQualifiedName = "TUnit.TestProject.ArgumentWithImplicitConverterTests.Explicit",
FilePath = @"",
FilePath = "",
LineNumber = 8,
Categories = global::System.Array.Empty<string>(),
Properties = global::System.Array.Empty<string>(),
Expand All @@ -125,7 +125,7 @@ global::TUnit.Core.ParameterMetadataFactory.Create(typeof(global::TUnit.TestProj
{
MethodName = "Implicit",
FullyQualifiedName = "TUnit.TestProject.ArgumentWithImplicitConverterTests.Implicit",
FilePath = @"",
FilePath = "",
LineNumber = 17,
Categories = global::System.Array.Empty<string>(),
Properties = global::System.Array.Empty<string>(),
Expand Down
14 changes: 7 additions & 7 deletions TUnit.Core.SourceGenerator.Tests/AssemblyAfterTests.Test.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ namespace TUnit.Generated
Order = 0,
RegistrationIndex = __registrationIndex,
Body = global::TUnit.Generated.Hooks.TUnit_TestProject_AfterTests_AssemblyBase1_AfterAll1_After_Assembly.TUnit_TestProject_AfterTests_AssemblyBase1_AfterAll1_After_AssemblyInitializer.global_TUnit_TestProject_AfterTests_AssemblyBase1_AfterAll1_0Params_Body,
FilePath = @"",
FilePath = "",
LineNumber = 5
}
);
Expand Down Expand Up @@ -198,7 +198,7 @@ namespace TUnit.Generated
Order = 0,
RegistrationIndex = __registrationIndex,
Body = global::TUnit.Generated.Hooks.TUnit_TestProject_AfterTests_AssemblyBase2_AfterAll2_After_Assembly.TUnit_TestProject_AfterTests_AssemblyBase2_AfterAll2_After_AssemblyInitializer.global_TUnit_TestProject_AfterTests_AssemblyBase2_AfterAll2_0Params_Body,
FilePath = @"",
FilePath = "",
LineNumber = 20
}
);
Expand Down Expand Up @@ -338,7 +338,7 @@ namespace TUnit.Generated
Order = 0,
RegistrationIndex = __registrationIndex,
Body = global::TUnit.Generated.Hooks.TUnit_TestProject_AfterTests_AssemblyBase3_AfterAll3_After_Assembly.TUnit_TestProject_AfterTests_AssemblyBase3_AfterAll3_After_AssemblyInitializer.global_TUnit_TestProject_AfterTests_AssemblyBase3_AfterAll3_0Params_Body,
FilePath = @"",
FilePath = "",
LineNumber = 35
}
);
Expand Down Expand Up @@ -478,7 +478,7 @@ namespace TUnit.Generated
Order = 0,
RegistrationIndex = __registrationIndex,
Body = global::TUnit.Generated.Hooks.TUnit_TestProject_AfterTests_AssemblyCleanupTests_AfterAllCleanUp_After_Assembly.TUnit_TestProject_AfterTests_AssemblyCleanupTests_AfterAllCleanUp_After_AssemblyInitializer.global_TUnit_TestProject_AfterTests_AssemblyCleanupTests_AfterAllCleanUp_0Params_Body,
FilePath = @"",
FilePath = "",
LineNumber = 50
}
);
Expand Down Expand Up @@ -551,7 +551,7 @@ namespace TUnit.Generated
Order = 0,
RegistrationIndex = __registrationIndex,
Body = global::TUnit.Generated.Hooks.TUnit_TestProject_AfterTests_AssemblyCleanupTests_AfterAllCleanUpWithContext__AssemblyHookContext_After_Assembly.TUnit_TestProject_AfterTests_AssemblyCleanupTests_AfterAllCleanUpWithContext__AssemblyHookContext_After_AssemblyInitializer.global_TUnit_TestProject_AfterTests_AssemblyCleanupTests_AfterAllCleanUpWithContext_1Params_Body,
FilePath = @"",
FilePath = "",
LineNumber = 56
}
);
Expand Down Expand Up @@ -621,7 +621,7 @@ namespace TUnit.Generated
Order = 0,
RegistrationIndex = __registrationIndex,
Body = global::TUnit.Generated.Hooks.TUnit_TestProject_AfterTests_AssemblyCleanupTests_AfterAllCleanUp2_After_Assembly.TUnit_TestProject_AfterTests_AssemblyCleanupTests_AfterAllCleanUp2_After_AssemblyInitializer.global_TUnit_TestProject_AfterTests_AssemblyCleanupTests_AfterAllCleanUp2_0Params_Body,
FilePath = @"",
FilePath = "",
LineNumber = 62
}
);
Expand Down Expand Up @@ -695,7 +695,7 @@ namespace TUnit.Generated
Order = 0,
RegistrationIndex = __registrationIndex,
Body = global::TUnit.Generated.Hooks.TUnit_TestProject_AfterTests_AssemblyCleanupTests_AfterAllCleanUpWithContextAndToken__AssemblyHookContext_CancellationToken_After_Assembly.TUnit_TestProject_AfterTests_AssemblyCleanupTests_AfterAllCleanUpWithContextAndToken__AssemblyHookContext_CancellationToken_After_AssemblyInitializer.global_TUnit_TestProject_AfterTests_AssemblyCleanupTests_AfterAllCleanUpWithContextAndToken_2Params_Body,
FilePath = @"",
FilePath = "",
LineNumber = 68
}
);
Expand Down
14 changes: 7 additions & 7 deletions TUnit.Core.SourceGenerator.Tests/AssemblyBeforeTests.Test.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ namespace TUnit.Generated
Order = 0,
RegistrationIndex = __registrationIndex,
Body = global::TUnit.Generated.Hooks.TUnit_TestProject_BeforeTests_AssemblyBase1_BeforeAll1_Before_Assembly.TUnit_TestProject_BeforeTests_AssemblyBase1_BeforeAll1_Before_AssemblyInitializer.global_TUnit_TestProject_BeforeTests_AssemblyBase1_BeforeAll1_0Params_Body,
FilePath = @"",
FilePath = "",
LineNumber = 5
}
);
Expand Down Expand Up @@ -198,7 +198,7 @@ namespace TUnit.Generated
Order = 0,
RegistrationIndex = __registrationIndex,
Body = global::TUnit.Generated.Hooks.TUnit_TestProject_BeforeTests_AssemblyBase2_BeforeAll2_Before_Assembly.TUnit_TestProject_BeforeTests_AssemblyBase2_BeforeAll2_Before_AssemblyInitializer.global_TUnit_TestProject_BeforeTests_AssemblyBase2_BeforeAll2_0Params_Body,
FilePath = @"",
FilePath = "",
LineNumber = 20
}
);
Expand Down Expand Up @@ -338,7 +338,7 @@ namespace TUnit.Generated
Order = 0,
RegistrationIndex = __registrationIndex,
Body = global::TUnit.Generated.Hooks.TUnit_TestProject_BeforeTests_AssemblyBase3_BeforeAll3_Before_Assembly.TUnit_TestProject_BeforeTests_AssemblyBase3_BeforeAll3_Before_AssemblyInitializer.global_TUnit_TestProject_BeforeTests_AssemblyBase3_BeforeAll3_0Params_Body,
FilePath = @"",
FilePath = "",
LineNumber = 35
}
);
Expand Down Expand Up @@ -478,7 +478,7 @@ namespace TUnit.Generated
Order = 0,
RegistrationIndex = __registrationIndex,
Body = global::TUnit.Generated.Hooks.TUnit_TestProject_BeforeTests_AssemblySetupTests_BeforeAllSetUp_Before_Assembly.TUnit_TestProject_BeforeTests_AssemblySetupTests_BeforeAllSetUp_Before_AssemblyInitializer.global_TUnit_TestProject_BeforeTests_AssemblySetupTests_BeforeAllSetUp_0Params_Body,
FilePath = @"",
FilePath = "",
LineNumber = 50
}
);
Expand Down Expand Up @@ -551,7 +551,7 @@ namespace TUnit.Generated
Order = 0,
RegistrationIndex = __registrationIndex,
Body = global::TUnit.Generated.Hooks.TUnit_TestProject_BeforeTests_AssemblySetupTests_BeforeAllSetUpWithContext__AssemblyHookContext_Before_Assembly.TUnit_TestProject_BeforeTests_AssemblySetupTests_BeforeAllSetUpWithContext__AssemblyHookContext_Before_AssemblyInitializer.global_TUnit_TestProject_BeforeTests_AssemblySetupTests_BeforeAllSetUpWithContext_1Params_Body,
FilePath = @"",
FilePath = "",
LineNumber = 56
}
);
Expand Down Expand Up @@ -621,7 +621,7 @@ namespace TUnit.Generated
Order = 0,
RegistrationIndex = __registrationIndex,
Body = global::TUnit.Generated.Hooks.TUnit_TestProject_BeforeTests_AssemblySetupTests_BeforeAllSetUp2_Before_Assembly.TUnit_TestProject_BeforeTests_AssemblySetupTests_BeforeAllSetUp2_Before_AssemblyInitializer.global_TUnit_TestProject_BeforeTests_AssemblySetupTests_BeforeAllSetUp2_0Params_Body,
FilePath = @"",
FilePath = "",
LineNumber = 62
}
);
Expand Down Expand Up @@ -695,7 +695,7 @@ namespace TUnit.Generated
Order = 0,
RegistrationIndex = __registrationIndex,
Body = global::TUnit.Generated.Hooks.TUnit_TestProject_BeforeTests_AssemblySetupTests_BeforeAllSetUpWithContext__AssemblyHookContext_CancellationToken_Before_Assembly.TUnit_TestProject_BeforeTests_AssemblySetupTests_BeforeAllSetUpWithContext__AssemblyHookContext_CancellationToken_Before_AssemblyInitializer.global_TUnit_TestProject_BeforeTests_AssemblySetupTests_BeforeAllSetUpWithContext_2Params_Body,
FilePath = @"",
FilePath = "",
LineNumber = 68
}
);
Expand Down
6 changes: 3 additions & 3 deletions TUnit.Core.SourceGenerator.Tests/AssemblyLoaderTests.Test.DotNet10_0.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ internal static class TUnit_TestProject_BasicTests__TestSource
{
MethodName = "SynchronousTest",
FullyQualifiedName = "TUnit.TestProject.BasicTests.SynchronousTest",
FilePath = @"",
FilePath = "",
LineNumber = 5,
Categories = global::System.Array.Empty<string>(),
Properties = global::System.Array.Empty<string>(),
Expand All @@ -107,7 +107,7 @@ internal static class TUnit_TestProject_BasicTests__TestSource
{
MethodName = "AsynchronousTest",
FullyQualifiedName = "TUnit.TestProject.BasicTests.AsynchronousTest",
FilePath = @"",
FilePath = "",
LineNumber = 11,
Categories = global::System.Array.Empty<string>(),
Properties = global::System.Array.Empty<string>(),
Expand All @@ -125,7 +125,7 @@ internal static class TUnit_TestProject_BasicTests__TestSource
{
MethodName = "ValueTaskAsynchronousTest",
FullyQualifiedName = "TUnit.TestProject.BasicTests.ValueTaskAsynchronousTest",
FilePath = @"",
FilePath = "",
LineNumber = 17,
Categories = global::System.Array.Empty<string>(),
Properties = global::System.Array.Empty<string>(),
Expand Down
6 changes: 3 additions & 3 deletions TUnit.Core.SourceGenerator.Tests/AssemblyLoaderTests.Test.DotNet8_0.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ internal static class TUnit_TestProject_BasicTests__TestSource
{
MethodName = "SynchronousTest",
FullyQualifiedName = "TUnit.TestProject.BasicTests.SynchronousTest",
FilePath = @"",
FilePath = "",
LineNumber = 5,
Categories = global::System.Array.Empty<string>(),
Properties = global::System.Array.Empty<string>(),
Expand All @@ -107,7 +107,7 @@ internal static class TUnit_TestProject_BasicTests__TestSource
{
MethodName = "AsynchronousTest",
FullyQualifiedName = "TUnit.TestProject.BasicTests.AsynchronousTest",
FilePath = @"",
FilePath = "",
LineNumber = 11,
Categories = global::System.Array.Empty<string>(),
Properties = global::System.Array.Empty<string>(),
Expand All @@ -125,7 +125,7 @@ internal static class TUnit_TestProject_BasicTests__TestSource
{
MethodName = "ValueTaskAsynchronousTest",
FullyQualifiedName = "TUnit.TestProject.BasicTests.ValueTaskAsynchronousTest",
FilePath = @"",
FilePath = "",
LineNumber = 17,
Categories = global::System.Array.Empty<string>(),
Properties = global::System.Array.Empty<string>(),
Expand Down
6 changes: 3 additions & 3 deletions TUnit.Core.SourceGenerator.Tests/AssemblyLoaderTests.Test.DotNet9_0.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ internal static class TUnit_TestProject_BasicTests__TestSource
{
MethodName = "SynchronousTest",
FullyQualifiedName = "TUnit.TestProject.BasicTests.SynchronousTest",
FilePath = @"",
FilePath = "",
LineNumber = 5,
Categories = global::System.Array.Empty<string>(),
Properties = global::System.Array.Empty<string>(),
Expand All @@ -107,7 +107,7 @@ internal static class TUnit_TestProject_BasicTests__TestSource
{
MethodName = "AsynchronousTest",
FullyQualifiedName = "TUnit.TestProject.BasicTests.AsynchronousTest",
FilePath = @"",
FilePath = "",
LineNumber = 11,
Categories = global::System.Array.Empty<string>(),
Properties = global::System.Array.Empty<string>(),
Expand All @@ -125,7 +125,7 @@ internal static class TUnit_TestProject_BasicTests__TestSource
{
MethodName = "ValueTaskAsynchronousTest",
FullyQualifiedName = "TUnit.TestProject.BasicTests.ValueTaskAsynchronousTest",
FilePath = @"",
FilePath = "",
LineNumber = 17,
Categories = global::System.Array.Empty<string>(),
Properties = global::System.Array.Empty<string>(),
Expand Down
Loading
Loading