You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Remaining argument-row and property-source checks match attributes by simple name #7650
The source generator still identifies some data-source attributes by their simple names. Unrelated attributes named ArgumentsAttribute, or custom property data sources named MethodDataSourceAttribute, can therefore enter parsing paths intended for TUnit attributes. Use qualified identities consistently so custom metadata is not interpreted as built-in rows.
Reproduction
Source inspection at commit 7780a6a on main shows simple-name checks in src/TUnit.Core.SourceGenerator/Generators/TestMetadataGenerator.cs (including lines 1050, 1060 and the class argument filtering near 1281), and src/TUnit.Core.SourceGenerator/CodeGenerators/StaticPropertyInitializationGenerator.cs lines 318–322. Apply a lookalike Arguments attribute to a generic class alongside real data sources; separately exercise a custom property data source with a built-in simple name. An end-to-end failure has not yet been established; regression fixtures should establish which branches are reachable.
Proposal
Audit these remaining argument-row and static-property checks, replace reachable built-in classification with qualified identity checks, and add regression fixtures with lookalike attributes. Check generated and reflection discovery agree where both modes apply. Consolidate repeated identity literals/helpers and avoid repeated symbol display conversion in the affected loops.
Environment
Source inspected on macOS at main commit 7780a6a and PR head e032133. This follows non-blocking review suggestions on #7649; that PR fixes method-source classification in generic test inference, while this issue covers remaining argument-row and property paths.
Please make the remaining built-in data-source classification ignore unrelated attributes with the same simple names.
Activity
fix(generator): preserve derived method data sources (#7650)
fix(generator): guard derived source inference (#7650)
fix(generator): guard derived source class inference (#7650)
fix(generator): qualify built-in data-source row classification (#7650)
fix(generator): preserve derived method data sources (#7650)
fix(generator): guard derived source inference (#7650)
fix(generator): guard derived source class inference (#7650)
fix(generator): preserve configured forwarding sources (#7650)
fix(generator): qualify built-in data-source row classification (#7650)
fix(generator): preserve derived method data sources (#7650)
fix(generator): guard derived source inference (#7650)
fix(generator): guard derived source class inference (#7650)
fix(generator): preserve configured forwarding sources (#7650)
Remove superseded method-source matcher after rebase (#7650)
Fix inference for reimplemented method-source rows (#7650)
fix(generator): preserve explicit derived source types (#7650)
fix: retain deferred derived source rows for explicit types (#7650)
fix(generator): qualify built-in data-source row classification (#7651)