Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 2aeb001 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Caution Review failedAn error occurred during the review process. Please try again later. WalkthroughThe changes remove Solidity compiler ( Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes 🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
| function parseSolidityInterfaces(source: string): ParsedInterface[] { | ||
| const results: ParsedInterface[] = []; | ||
|
|
||
| const ifaceRegex = /interface\s+(I?[A-Za-z0-9_]+)\s*\{([\s\S]*?)\n\}/g; |
There was a problem hiding this comment.
The interface regex requires a newline before the closing brace (\n}), which will fail to match interfaces that don't have this specific formatting. For example, interface IFoo { function bar(); } or interfaces with spaces/tabs before the closing brace will not be detected.
Impact: Valid interfaces will be silently skipped, potentially resulting in zero interfaces found and process exit with error "No interfaces found in ABI output."
Fix: Remove the newline requirement from the regex:
const ifaceRegex = /interface\s+(I?[A-Za-z0-9_]+)\s*\{([\s\S]*?)\}/g;| const ifaceRegex = /interface\s+(I?[A-Za-z0-9_]+)\s*\{([\s\S]*?)\n\}/g; | |
| const ifaceRegex = /interface\s+(I?[A-Za-z0-9_]+)\s*\{([\s\S]*?)\}/g; |
Spotted by Graphite
Is this helpful? React 👍 or 👎 to let us know.
size-limit report 📦
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8726 +/- ##
=======================================
Coverage 52.73% 52.73%
=======================================
Files 934 934
Lines 62968 62968
Branches 4136 4138 +2
=======================================
Hits 33204 33204
Misses 29666 29666
Partials 98 98
🚀 New features to boost your workflow:
|
PR-Codex overview
This PR focuses on improving the
styluscommand in thethirdwebCLI by removing unnecessary checks for thesolccompiler, enhancing ABI generation, and refining interface parsing.Detailed summary
solccompiler increate.tsandbuilder.ts.solc.parseAbiItemimport for better ABI parsing.Summary by CodeRabbit
Bug Fixes
Chores