Skip to content

Revert "ASoC: SOF: Intel: hda-bus: Use PIO mode for Lunar Lake"#4892

Closed
plbossart wants to merge 1 commit intothesofproject:topic/sof-devfrom
plbossart:test/4889
Closed

Revert "ASoC: SOF: Intel: hda-bus: Use PIO mode for Lunar Lake"#4892
plbossart wants to merge 1 commit intothesofproject:topic/sof-devfrom
plbossart:test/4889

Conversation

@plbossart
Copy link
Member

This reverts commit 9bb1cad.

Link: #4889

This reverts commit 9bb1cad.

Link: thesofproject#4889
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Copy link
Collaborator

@marc-hb marc-hb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean revert of the small and last commit in #4844. If removing these 3 lines is all it takes to get some LNL test coverage again then great.

Can you confirm there was no attempt yet to upstream the other 4 commits?

@marc-hb
Copy link
Collaborator

marc-hb commented Mar 29, 2024

@plbossart
Copy link
Member Author

I am not sure if we want to apply this revert, because we would fail HDaudio stress tests. I just provided this PR to make sure others could reproduce my painful bisect work.

We first need to root-cause why this PIO mode interferes with SoundWire-based interfaces.

@plbossart
Copy link
Member Author

plbossart commented Apr 2, 2024

false positive, the problem is the WAKE_STS clear missing, see

@plbossart plbossart closed this Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants