ASoC: SOF: dont wake dsp up in kcontrol set/get

[bardliao]

Cache the kcontrol value in host. Always get kcontrol value from cache,
set kcontrol value to DSP when DSP is active. Kcontrol values will be
restored when DSP is boot.

Signed-off-by: Bard liao bard.liao@intel.com

[bardliao]

I verified volume kcontrol works fine. But I didn't test the binary type kcontro yet since l ave no idea how to test it. Sorry about that. The PR is for issue #166

[lgirdwood]

@singalsu can help you with testing it using new soft equctl cmd line program.

[singalsu]

OK, I'll try this PR #168.

[singalsu]

Here's some results. Generally the ext bytes put seems to work. The 1st sof-eqctl activated a bandpass response that was audible. Though the 1st command returned fail that should not happen when things are correct.

Ext bytes get doesn't work in idle nor active during playback. The 1st read effort was done in idle and the 2nd while music was playing. Though I've seen with these controls that a single fail will make next control efforts fail too and I don't know why. When success it should show the previously applied filter coefficients.

The last ext bytes put had also impact (I heard bassboost) even if TLV Write claimed fail.

singalsu@piikkisika:~/bin$ ./sof-eqctl -n 22 -s eq_iir_bandpass.txt 
Applying configuration "eq_iir_bandpass.txt" into device hw:0 control numid=22.
84,2,1,0,0,2,2,3316150158,2048164275,513807534,3267352229,513807534,0,16384,3867454526,1191025347,38870735,77741469,38870735,4294967294,16458
Error: failed TLV write.
singalsu@piikkisika:~/bin$ ./sof-eqctl -n 22
Retrieving configuration for device hw:0 control numid=22.
Error: failed TLV read.
singalsu@piikkisika:~/bin$ ./sof-eqctl -n 22
Retrieving configuration for device hw:0 control numid=22.
Error: failed TLV read.
singalsu@piikkisika:~/bin$ ./sof-eqctl -n 22 -s eq_iir_bassboost.txt 
Applying configuration "eq_iir_bassboost.txt" into device hw:0 control numid=22.
84,2,1,0,0,2,2,3227172081,2141520527,536653443,3221660410,536653443,0,16384,3260252783,2107733822,161646111,3961037800,172645501,4294967294,27910
Error: failed TLV write.
singalsu@piikkisika:~/bin$ ./sof-eqctl -n 22
Retrieving configuration for device hw:0 control numid=22.
Error: failed TLV read.

[singalsu]

You can get this tool into SOFT from PR #74. It works with already merged SOFT/topology/sof-apl-eq-pcm512x.tplg.

[ranj063]

@bardliao one thing to also keep in mind is that when you make a change to the kcontrol through amixer put(), it is always followed by a get(). So it might be necessary to also check the the runtime status in get().

[bardliao]

@singalsu @lgirdwood @ranj063 Thanks Seppo, I can test it on my side now. The error is due to uninitialized return value ret. I.e ret is not assigned to 0 when it is declared. So the byte _put/_get function return an unexpected value. Initialize int ret = 0; can fix the issue. But I see ipc error when the control is set in playback.
error: ipc error for 0x50030000 size 0x180
error: failed to set control 0 values
It shows the same ipc error if I revert my patch. So, I think it is not cause by my patch. Probably some patches are not merged on my side yet.