Repository navigation
Fix Python 3.9 type hint syntax evaluation errors - #1
Merged
Merged
Conversation
- Updates all SQLAlchemy models to use Optional[X] instead of X | None to maintain backwards compatibility with Python 3.9 when Mapped type hints are dynamically evaluated. - Installs eval-type-backport in requirements.txt to allow Pydantic to safely parse X | None types dynamically under Python 3.9.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference: Fail to launch the server
Background: While Python 3.9 supports the PEP 563 stringified union type hints natively when skipping evaluation, robust systems like SQLAlchemy 2.0 and Pydantic dynamically invoke eval() on these annotations at runtime. Evaluating str | None using type objects without Python 3.10 produces an immediate TypeError. This was silently preventing developers on Python 3.9 from successfully executing scripts/start.sh during the SQLite database schema setup and artifact seeding.