Set SABnzbd graph color to accent color - #713
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the SABnzbd download graph colors to use the accent color instead of the button color, making it consistent with other UI elements like the speed limit slider and navbar buttons. This change also fixes a visual issue in Catppuccin themes where the graph was invisible due to matching background and foreground colors.
Changes:
- Changed SVG Peity graph polygon fill color from
--button-colorto--accent-color - Changed SVG Peity graph polyline stroke color from
--button-colorto--accent-color
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
Thanks! Lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #712
I have read the contributing guideline and understand that I have made the correct modifications
PR's are done against the develop branch.
Description:
Changes the download graph color to
--accent-color. In practice, this makes the download graph match the colors of the buttons on the right of the navbar and the download limiting slider. In the normal SABnzbd theme, the graph and the slider are the same colors. See #712 for more information.Before:
After:
Benefits of this PR and context:
See #712, but the gist is that this makes the theme closer to the normal SABnzbd theme in terms of what colors are used where. Also fixes the Catppuccin themes entirely, as the background and foreground of the graph are the same with how it currently is.
How Has This Been Tested?
Stylus extension manually copying the CSS files. Only looked at catppuccin-mocha, however this shouldn't negatively affect other themes since the graph will match the buttons on the right which already have contrast with the background.
Source / References:
#712