Skip to content

DeliveryModule wasn't correctly retrieved. - #40

Closed
TheCoreDev31 wants to merge 3 commits into
thelia-modules:masterfrom
TheCoreDev31:master
Closed

TheCoreDev31 wants to merge 3 commits into
thelia-modules:masterfrom
TheCoreDev31:master

Conversation

@TheCoreDev31

Copy link
Copy Markdown

Previously, the function was getting the first encountered module, event if it wasn't a delivery module.
Therefore, postage data retrieved later (line 414) returned an error.
Now, we get the right delivery module (from the order object).

Previously, the function was getting the first encountered module, event if it wasn't a delivery module.
Therefore, postage data retrieved later (line 414) returned an error.
Now, we get the right delivery module (from the order object).
DeliveryModule wasn't correctly retrieved.
@anoziere

Copy link
Copy Markdown
Contributor

Thanks for this. It targets a branch we no longer maintain: the module now lives on main for Thelia 3 and thelia2 for Thelia 2, so we are closing it. If the change still applies, rebase it onto one of those branches and reopen it, or open a new pull request, and we will review it.

@anoziere anoziere closed this Oct 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants