Conversation
added 4 commits
October 2, 2026 10:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On a Thelia 3 shop with the
default-twigback office, the label generator of the order page does nothing:order-edit-js.html.twiginserts the label table into#bill. Indefault-twigthe invoicing pane is#tab-bill, so the table and the "Generate new label" button never appear.bootstrap.Modal.getOrCreateInstance()while the page is still being parsed. Indefault-twigBootstrap is exposed by a deferred module, so the script stops withbootstrap is not definedbefore the click handlers are bound.OrderController::generateLabelAction()redirects to the label list. The modal expects JSON (json.error), parses the HTML of the redirect and showsSyntaxError: Unexpected token '<'.The same SOAP failure on
/admin/module/ColissimoLabel/bordereau/generateis not caught and ends as a 500.Changes
order-edit-js.html.twig: look for#tab-billfirst and fall back to#bill; run the script onDOMContentLoaded.OrderController: with?edit-order=1, a failure returns{"error": "<message>"}with a 500 status instead of a redirect. The label page keeps its redirect and its error context.BordereauController: aSoapFaultis shown on the bordereau list like the other errors of that page.How to check
On a base where the endpoint of the module points to an address that never answers (for example
https://example.invalid/ws?wsdl):SOAP-ERROR: Parsing WSDL: Couldn't load from ..., the response isapplication/jsonwith status 500, and no row is added tocolissimo_label./admin/module/ColissimoLabel/bordereau/generateshows the same message in the page.Checked in a browser on Thelia 3.2 / default-twig. No change to the SOAP request, the stored data or the configuration keys.
Not covered
The
default(Smarty) templates are untouched. A successful generation against the real service was not run.