Skip to content

fix: harden ciphernode runtime and Rust architecture [skip-line-limit] - #1691

Merged
ctrlc03 merged 62 commits into
mainfrom
fix/production-readiness-audit
Jul 14, 2026
Merged

ctrlc03 merged 62 commits into
mainfrom
fix/production-readiness-audit

Conversation

@hmzakhalid

@hmzakhalid hmzakhalid commented Jul 11, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

This draft PR carries the production-readiness and Rust architecture pass for the ciphernode and its protocol-critical dependencies.

  • fixes replay crash loops and propagates backpressure through the startup event pipeline;
  • hardens durable storage, schema preflight, snapshot atomicity, logical-clock recovery, shutdown draining, and supervisor cleanup;
  • bounds and validates network ingress, historical synchronization, startup buffers, DHT metadata, and external serialization;
  • strengthens EVM confirmation, parsing, nonce, receipt, replay, and slashing-effect behavior;
  • binds proof/share aggregation to canonical E3, signer, committee, party, phase, parameter, and multiplicity invariants;
  • keeps the development/test program server token-free, removes callback-origin setup, and retains bounded webhook delivery, payload logging, and job concurrency;
  • updates compatible vulnerable dependencies without adding release-policy or supply-chain test machinery;
  • adds the final 45-package runtime and protocol architecture map under agent/.

No Solidity public ABI, deployed storage layout, Noir circuit source, circuit semantics, wire format, production deployment, key, secret, fund, release, or publication action is included.

Validation

  • pnpm rust:test: PASS, 1,108 listed tests; real 1,021.30s; no failures.
  • e3-tests actor integration: 3 passed, 2 ignored; TRBFV completed in 354.79s.
  • correlated NodeFold proof/verify E2E: 1 passed in 82.01s.
  • cargo check --workspace --all-targets --locked: PASS in 1m41s.
  • cargo clippy --workspace --all-targets --locked -- -D warnings: PASS in 1m03s.
  • cargo test --workspace --doc --locked: PASS.
  • cargo fmt --all -- --check and git diff --check: PASS.
  • pre-push repository lint, pnpm/license, and committee consistency hooks: PASS; existing Solidity lint emitted 3 warnings and nargo was unavailable, so the hook skipped Noir lint.
  • cargo audit --no-fetch: reduced from 18 to 5 vulnerabilities; remains non-zero and is tracked by Upgrade libp2p TLS and DNS stack to clear remaining RustSec advisories #1690.
  • circuit diff versus main: empty.
  • default-template locked support build and CRISP wasm-target locked check: PASS.
  • token-free and callback-origin-free program-server regressions: PASS (8 Rust server tests); focused CRISP and template token-free regressions previously passed.
  • C0/C6 restart recovery regressions (restored_): PASS (2 tests; 128 filtered).

Docker-backed disk-full/partition fault injection was not run because the Docker daemon is unavailable. The standalone crates/support-scripts/dev manifest remains blocked by its pre-existing workspace-membership error.

Fixed issues

Follow-up risk

CI follow-up fixes

@vercel

vercel Bot commented Jul 11, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
crisp Ready Ready Preview, Comment Jul 14, 2026 6:29pm
interfold-dashboard Ready Ready Preview, Comment Jul 14, 2026 6:29pm
interfold-docs Ready Ready Preview, Comment Jul 14, 2026 6:29pm

Request Review

@hmzakhalid hmzakhalid changed the title [skip-line-limit] fix: harden ciphernode runtime and Rust architecture fix: harden ciphernode runtime and Rust architecture [skip-line-limit] Jul 11, 2026
@hmzakhalid
hmzakhalid marked this pull request as ready for review July 11, 2026 20:07
@neogiacomo
neogiacomo requested review from ctrlc03 and neogiacomo July 12, 2026 09:30
@vercel
vercel Bot temporarily deployed to Preview – interfold-docs July 12, 2026 11:13 Inactive
@vercel
vercel Bot temporarily deployed to Preview – crisp July 12, 2026 11:13 Inactive
Comment thread crates/zk-prover/src/actors/proof_verification.rs Outdated

This branch was successfully deployed

3 active deployments
Preview – interfold-docs — 4cca970c Deployed Jul 14, 2026 by vercel[bot]
Preview – crisp — 4cca970c Deployed Jul 14, 2026 by vercel[bot]
Preview – interfold-dashboard — 4cca970c Deployed Jul 14, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment