Skip to content

Add Cursor skill to review assemblies for single user story#4723

Open
aneta-petrova wants to merge 3 commits intotheforeman:masterfrom
aneta-petrova:cursor-command-user-story
Open

Add Cursor skill to review assemblies for single user story#4723
aneta-petrova wants to merge 3 commits intotheforeman:masterfrom
aneta-petrova:cursor-command-user-story

Conversation

@aneta-petrova
Copy link
Copy Markdown
Member

@aneta-petrova aneta-petrova commented Mar 18, 2026

What changes are you introducing?

Add a new Cursor skill that reviews assembly files to ensure they follow the one-user-story principle. The skill analyzes assemblies and can split them into multiple files if they contain multiple independent user stories.

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

The requirement that each assembly is a single user story is part of the downstream Content Quality Assessment checklist.

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

N/A

Contributor checklists

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

Please cherry-pick my commits into:

  • Foreman 3.18/Katello 4.20 (Satellite 6.19)
  • Foreman 3.17/Katello 4.19
  • Foreman 3.16/Katello 4.18 (Satellite 6.18; orcharhino 7.6 and 7.7)
  • Foreman 3.15/Katello 4.17
  • Foreman 3.14/Katello 4.16 (Satellite 6.17; orcharhino 7.4; orcharhino 7.5)
  • Foreman 3.13/Katello 4.15 (EL9 only)
  • Foreman 3.12/Katello 4.14 (Satellite 6.16; orcharhino 7.2 on EL9 only; orcharhino 7.3)
  • We do not accept PRs for Foreman older than 3.12.

aneta-petrova and others added 2 commits March 18, 2026 19:23
Add a new Cursor skill that reviews assembly files to ensure they follow the one-user-story principle. The skill analyzes assemblies and can split them into multiple files if they contain multiple independent user stories.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@github-actions github-actions Bot added Needs tech review Requires a review from the technical perspective Needs style review Requires a review from docs style/grammar perspective labels Mar 18, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 18, 2026

The PR preview for 4be0c6a is available at theforeman-foreman-documentation-preview-pr-4723.surge.sh

No diff compared to the current base

show diff

@aneta-petrova
Copy link
Copy Markdown
Member Author

I used this skill for #4758. I think it worked quite nicely so I'm switching this to ready for review. I'd be interesting in hearing your thoughts and feedback, and I plan to raise one more PR very soon to test this again.

@aneta-petrova aneta-petrova marked this pull request as ready for review April 21, 2026 13:56
@Lennonka
Copy link
Copy Markdown
Contributor

Oooh, exciting! Will try it out next week.

@aneta-petrova
Copy link
Copy Markdown
Member Author

Another PR where I tested this skill: #4793 There, I called the skill but also explicitly asked for one assembly for global registration, one for bootstrap registration, and I let the rest to the agent to figure out. IMO it worked very well.

@aneta-petrova
Copy link
Copy Markdown
Member Author

Another PR where I tested this skill: #4793 There, I called the skill but also explicitly asked for one assembly for global registration, one for bootstrap registration, and I let the rest to the agent to figure out. IMO it worked very well.

And later during my work on that PR, I also referenced that skill in various ways when I wanted to check whether the assemblies I'm creating adhere to the single user story guideline. To me, it's really proved very useful and because I saw it deliver reliable results multiple times, I'm going to set testing done.

If this PR is acked, that would qualify as style review done. (Or at least that's my perspective on how we can review these AI files 🤷)

@aneta-petrova aneta-petrova added testing done No issues from the functional perspective and removed Needs tech review Requires a review from the technical perspective labels Apr 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs style review Requires a review from docs style/grammar perspective Not yet reviewed testing done No issues from the functional perspective

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants