Ignore long2ip() that is actually safe#671
Merged
silasjoisten merged 1 commit intothecodingmachine:masterfrom May 13, 2025
cedric-anne:change/ignore-long2ip
Merged
Ignore long2ip() that is actually safe#671silasjoisten merged 1 commit intothecodingmachine:masterfrom cedric-anne:change/ignore-long2ip
long2ip() that is actually safe#671silasjoisten merged 1 commit intothecodingmachine:masterfrom
cedric-anne:change/ignore-long2ip
Conversation
silasjoisten
approved these changes
May 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See php/php-src#13395 and the mentioned vimeo/psalm#9537 (comment) discussion.
The
falsereturn value documented for thelong2ip()function can actually never happen. UsingSafe/long2ip()instead will then never have any value.I propose to ignore it. This will prevent to have differences in detected error between PHP 8.4 and previous PHP versions.