Conversation
…filter config GatewayController resolved cross-namespace AIServiceBackend/InferencePool backends (and their BackendSecurityPolicy credentials) into the shared extproc filter-config Secret without checking a ReferenceGrant, even though AIGatewayRouteController already enforces one for HTTPRoute generation. Gate both backend kinds on the same check. Also reconcile BackendSecurityPolicy on grant changes. ReferenceGrantController only requeued AIGatewayRoutes when a ReferenceGrant changed, so a BackendSecurityPolicy left NotAccepted for lacking a grant to its Secret wouldn't re-reconcile until something else touched it. Requeue affected BackendSecurityPolicies too. Signed-off-by: Ignasi Barrera <ignasi@tetrate.io>
✅ Deploy Preview for theagentrouter canceled.
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
GatewayController resolved cross-namespace AIServiceBackend/InferencePool backends (and their BackendSecurityPolicy credentials) into the shared extproc filter-config Secret without checking a ReferenceGrant, even though AIGatewayRouteController already enforces one for HTTPRoute generation. Gate both backend kinds on the same check.
Also reconcile BackendSecurityPolicy on grant changes. ReferenceGrantController only requeued AIGatewayRoutes when a ReferenceGrant changed, so a BackendSecurityPolicy left NotAccepted for lacking a grant to its Secret wouldn't re-reconcile until something else touched it. Requeue affected BackendSecurityPolicies too.
Related Issues/PRs (if applicable)
N/A
Special notes for reviewers (if applicable)
N/A