feat(avatar): resolve GitHub noreply emails and support per-email overrides - #88
Open
arumata wants to merge 1 commit into
Open
feat(avatar): resolve GitHub noreply emails and support per-email overrides#88arumata wants to merge 1 commit into
arumata wants to merge 1 commit into
Conversation
…rrides Commit authors using GitHub's private "noreply" email previously got Gravatar's generated "retro" placeholder instead of their real avatar. Noreply addresses (<id>+<login> and <login> at users.noreply.github.com) now resolve to avatars.githubusercontent.com. Adds gitGraphPlus.avatarOverrides so an author whose email has neither a Gravatar account nor a noreply address can be mapped to an explicit https avatar URL (keys matched case-insensitively).
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit authors using GitHub's private "noreply" email previously got Gravatar's generated "retro" placeholder instead of their real avatar. This PR:\n\n- resolves
<id>+<login>@users.noreply.github.comand<login>@users.noreply.github.comtoavatars.githubusercontent.com;\n- adds agitGraphPlus.avatarOverridessetting to map any email to an explicit avatar URL (for authors with neither a Gravatar account nor a noreply address).