Settings.txt generating script#7
Open
RkShaRkz wants to merge 7 commits into
Open
Conversation
Based on darkstorm's one from Discord, but with a bit more customizability, less code repetition, and much better error-handling. Also, in BASH format. So should work fine on Macs and linux machines. If only we could somehow make a batch file to execute this, without WSL and other required things...
RkShaRkz
commented
Feb 25, 2024
Contributor
Author
RkShaRkz
left a comment
RkShaRkz
left a comment
There was a problem hiding this comment.
Please address comments. seems fine but not quite there yet.
on the other hand, here's a sample generated file:
settings.txt
used the following input: 5, 28, 8, 4, n, 2, s, y, y, s, s, s, 1, 4, 3, n
Using --no-particles unless specifically answered with Y or y.
Parametrized two more aspects of the settings.txt: 1) the wizards, as an enumerated list, with names taken from https://github.com/tg-2/sacengine/blob/2883cb6f3b0115ad93f14095c1d06821d77a4ccb/source/nttData.d#L857 2) the screen resolution in the WidthxHeight format that allows 3 or 4 digits for resolutions. Also has warning that it's an advanced functionality. - bugfixed the resolution check since regexes don't work in bash like they do everywhere else - made skipping possible by just pressing enter (empty input) - changed tabs back to normal spaces
RkShaRkz
commented
Feb 25, 2024
Contributor
Author
RkShaRkz
left a comment
RkShaRkz
left a comment
There was a problem hiding this comment.
Address these comments please
Contributor
Author
|
LGTM |
tg-2
force-pushed
the
master
branch
3 times, most recently
from
b990e5b to
84b7fb5
Compare
tg-2
force-pushed
the
master
branch
2 times, most recently
from
4a59672 to
da21be2
Compare
tg-2
force-pushed
the
master
branch
2 times, most recently
from
0a7591a to
c1f8763
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on darkstorm's one from Discord, but with a bit more customizability, less code repetition, and much better error-handling.
Also, in BASH format. So should work fine on Macs and linux machines. If only we could somehow make a batch file to execute this, without WSL and other required things...