Use object's display alias for ShowMenuResponse during disambiguation#1389
Merged
alexwarren merged 3 commits intotextadventures:masterfrom Jan 20, 2025
KVonGit:ShowMenuResponse-uses-displayalias
Merged
Use object's display alias for ShowMenuResponse during disambiguation#1389alexwarren merged 3 commits intotextadventures:masterfrom KVonGit:ShowMenuResponse-uses-displayalias
alexwarren merged 3 commits intotextadventures:masterfrom
KVonGit:ShowMenuResponse-uses-displayalias
Conversation
- Use `GetDisplayAlias` to print selection made in `ShowMenuResponse` - Add "donotclearmenus" boolean attribute to game object, default false - Add "showmenuresponses" boolean attribute to game object, default false - Add `DisableMenu` function - Add DisableOutputSection function - Add JS `disableCmdLink` function - Add editor controls for new game object attributes Co-Authored-By: Pertex <Pertex@users.noreply.github.com>
Change function names to something more logical
- Check `game.showmenuresponses` regardless of `game.disambiguating` value
alexwarren
approved these changes
Jan 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GetDisplayAliasto print selection made inShowMenuResponsefalsefalseDisableMenufunctionDisableMenuOutputSectionfunctiondisableMenuOutputSectionfunctionScreenshot (Editor Controls)
Animated GIF 1
Animated GIF 2
Test game:
Testing GetDisplayAlias in ShowMenuResponse.zip