Skip to content

Pertex - Add custom location bar background image option#1347

Merged
alexwarren merged 3 commits intotextadventures:masterfrom
KVonGit:Custom-Location-Image
Jan 15, 2025
Merged

Pertex - Add custom location bar background image option#1347
alexwarren merged 3 commits intotextadventures:masterfrom
KVonGit:Custom-Location-Image

Conversation

@KVonGit
Copy link
Copy Markdown
Contributor

@KVonGit KVonGit commented Jan 2, 2025

Submitted by Pertex

Add option to use custom image in the location bar, complete with editor controls

Can use URL or local image

Screenshot

image

PertexTester.aslx
<!--Saved by Quest 5.9.9123.20989-->
<asl version="580">
  <include ref="English.aslx" />
  <include ref="Core.aslx" />
  <game name="pertex tester">
    <gameid>af60d15c-82de-4042-b14a-432ba7ac84e6</gameid>
    <version>1.0</version>
    <firstpublished>2024</firstpublished>
    <classiclocation type="boolean">false</classiclocation>
    <locationbarimage>https://secure.gravatar.com/avatar/4cc1e52f99452e841ecf4cbee9eadde9?d=retro</locationbarimage>
    <locationbarimageisurl />
    <showlocation />
    <customlocationtextcolour>Transparent</customlocationtextcolour>
  </game>
  <object name="room">
    <inherit name="editor_room" />
    <isroom />
    <object name="player">
      <inherit name="editor_object" />
      <inherit name="editor_player" />
    </object>
  </object>
</asl>

Submitted by Pertex

Add option to use custom image in the location bar, complete with editor controls

Can use URL or local image

Co-Authored-By: Pertex <Pertex@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@alexwarren alexwarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of comments.

I'm also wondering if we actually really want the ability to load from an external URL? I think it's better for games to include all the resources they need within the game itself?

Comment thread WorldModel/WorldModel/Core/Core.aslx Outdated
Comment thread WorldModel/WorldModel/Core/Core.aslx Outdated
Also remove editor controls and templates concerning the use of a URL rather than a filename.
Comment thread WorldModel/WorldModel/Core/Core.aslx Outdated
Also keep the `url` variable inside the `if`

Co-authored-by: Alex Warren <alex@alexwarren.uk>
@KVonGit
Copy link
Copy Markdown
Contributor Author

KVonGit commented Jan 15, 2025

I applied your suggested changes directly from your comment. (Not sure if that sends a notification.)

@alexwarren alexwarren merged commit f7282e5 into textadventures:master Jan 15, 2025
@KVonGit KVonGit deleted the Custom-Location-Image branch January 15, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants