Pertex - Add custom location bar background image option#1347
Merged
alexwarren merged 3 commits intotextadventures:masterfrom Jan 15, 2025
KVonGit:Custom-Location-Image
Merged
Pertex - Add custom location bar background image option#1347alexwarren merged 3 commits intotextadventures:masterfrom KVonGit:Custom-Location-Image
alexwarren merged 3 commits intotextadventures:masterfrom
KVonGit:Custom-Location-Image
Conversation
Submitted by Pertex Add option to use custom image in the location bar, complete with editor controls Can use URL or local image Co-Authored-By: Pertex <Pertex@users.noreply.github.com>
alexwarren
requested changes
Jan 13, 2025
Contributor
alexwarren
left a comment
There was a problem hiding this comment.
Left a couple of comments.
I'm also wondering if we actually really want the ability to load from an external URL? I think it's better for games to include all the resources they need within the game itself?
Also remove editor controls and templates concerning the use of a URL rather than a filename.
alexwarren
reviewed
Jan 15, 2025
Also keep the `url` variable inside the `if` Co-authored-by: Alex Warren <alex@alexwarren.uk>
Contributor
Author
|
I applied your suggested changes directly from your comment. (Not sure if that sends a notification.) |
alexwarren
approved these changes
Jan 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submitted by Pertex
Add option to use custom image in the location bar, complete with editor controls
Can use URL or local image
Screenshot
PertexTester.aslx