Repository navigation
fix(oauth): reject read-only credentials before starting login - #905
Conversation
|
Makes sense, failing before the flow beats failing after it. Small asks: move the afterEach into the login describe, keep only "unset it before e2e login" in subscriptions.mdx, and drop the skills/setup.md change. |
Signed-off-by: Rudy Celekli <47457359+rudycelekli@users.noreply.github.com>
Signed-off-by: Rudy Celekli <rudy@gradiahq.com>
5fc8787 to
1325f53
Compare
|
[gpt-6.1-sol] responding on behalf of rudycelekli Moved afterEach into the login describe, kept only the requested unset-before-login sentence, and removed the skills addition. Focused tests and the rebuilt CLI readonly-store consumer pass. Direct package typecheck and lint pass. The full monorepo check remains blocked at the same missing filtered mobile-benchmark dependency on untouched main; the current full Next benchmark was not rerun with this lean dependency environment. Hosted fork workflow authorization is reported separately; I am not marking these Ready for Human Review. |
logincompleted the provider flow, then discovered it could not save the result. A supplied writable store still takes precedence over the environment variable.Verified
Ran it locally: yes
Invoked the actual built CLI in a temporary project with
E2E_OAUTH_CREDENTIALS={}ande2e login github-copilot --client-id local-proof. Only that process's provider fetch was routed to a controlled loopback HTTP endpoint. No external credentials, browser authorization, model or provider account was used.pnpm checkstops at the filtered install's unused Expo mobile dependency finding, also observed on main. Full native mobile verification requires those omitted dependencies. No runner, engine or model behavior was changed.AI assistance: implemented and independently reviewed with Codex, with built CLI before/after evidence.
Current-head workflows awaiting maintainer authorization: docs, mobile, benchmark, spec.
Updated verification (October 6)
Moved afterEach into the login describe, kept only the requested unset-before-login sentence, and removed the skills addition. Focused tests and the rebuilt CLI readonly-store consumer pass.
Direct package typecheck and lint pass. The full monorepo check remains blocked at the same missing filtered mobile-benchmark dependency on untouched main; the current full Next benchmark was not rerun with this lean dependency environment. Hosted fork workflow authorization is reported separately; I am not marking these Ready for Human Review.