Skip to content

Added support for auto and deprecated automatic field in google_secret_manager_secret resource#522

Merged
modular-magician merged 1 commit into
terraform-google-modules:masterfrom
modular-magician:downstream-pr-1e2b51e482bb5fa85dfc7ff3c3f915f1d5cad565
Sep 11, 2023
Merged

Added support for auto and deprecated automatic field in google_secret_manager_secret resource#522
modular-magician merged 1 commit into
terraform-google-modules:masterfrom
modular-magician:downstream-pr-1e2b51e482bb5fa85dfc7ff3c3f915f1d5cad565

Conversation

@modular-magician

Copy link
Copy Markdown
Collaborator

Added support for the auto field and deprecated automatic field in the google_secret_manager_secret resource
fixes hashicorp/terraform-provider-google#10679
fixes hashicorp/terraform-provider-google#9272
fixes hashicorp/terraform-provider-google#14282

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

secretmanager: added `auto` field to `google_secret_manager_secret` resource
secretmanager: deprecated `automatic` field on `google_secret_manager_secret`. Use `auto` instead.

Derived from GoogleCloudPlatform/magic-modules#8838

…secret_manager_secret` resource (#8838)

* Added support for automatic_replication field in google_secret_manager_secret resource

* Replaced deprecated field automatic with automatic_replication in terraform configs

* Improved the deprecation_message

* Changed the name of field from automatic_replication to auto

* Adjusted white spaces

* Added test case to cover the automatic field

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 6284955 into terraform-google-modules:master Sep 11, 2023
@modular-magician modular-magician deleted the downstream-pr-1e2b51e482bb5fa85dfc7ff3c3f915f1d5cad565 branch November 18, 2024 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant