Skip to content

Add support for setting sendPreviousResourceOnDelete for FHIR store notification configs.#482

Merged
modular-magician merged 1 commit into
terraform-google-modules:masterfrom
modular-magician:downstream-pr-20768d52a81ac57c7475c46b60a54162bcb37fc8
Aug 2, 2023
Merged

Add support for setting sendPreviousResourceOnDelete for FHIR store notification configs.#482
modular-magician merged 1 commit into
terraform-google-modules:masterfrom
modular-magician:downstream-pr-20768d52a81ac57c7475c46b60a54162bcb37fc8

Conversation

@modular-magician

Copy link
Copy Markdown
Collaborator

Fixes hashicorp/terraform-provider-google#15349.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

healthcare: added `send_previous_resource_on_delete` field to `notification_configs` of `google_healthcare_fhir_store`

Derived from GoogleCloudPlatform/magic-modules#8507

… notification configs. (#8507)

* Add support for setting `sendPreviousResourceOnDelete` for FHIR store notification configs.

* Add test for sendPreviousResourceOnDelete

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 6e13786 into terraform-google-modules:master Aug 2, 2023
@modular-magician modular-magician deleted the downstream-pr-20768d52a81ac57c7475c46b60a54162bcb37fc8 branch November 18, 2024 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for sendPreviousResourceOnDelete field for configured pub/sub notifications in FHIR stores.

1 participant