Skip to content

Add continuousBackupConfig and continuousBackupInfo to AlloyDB cluster#480

Merged
modular-magician merged 1 commit into
terraform-google-modules:masterfrom
modular-magician:downstream-pr-ed8f2d42602fbc393ca4d5cfbf098b1c8ecd4ce4
Aug 1, 2023
Merged

Add continuousBackupConfig and continuousBackupInfo to AlloyDB cluster#480
modular-magician merged 1 commit into
terraform-google-modules:masterfrom
modular-magician:downstream-pr-ed8f2d42602fbc393ca4d5cfbf098b1c8ecd4ce4

Conversation

@modular-magician

Copy link
Copy Markdown
Collaborator

Add continuousBackupConfig and continuousBackupInfo to AlloyDB cluster.

Fixes hashicorp/terraform-provider-google#15110
b/291745106
Part of hashicorp/terraform-provider-google#13757
b/284523617

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

AlloyDB: added `continuous_backup_config` and `continuous_backup_info` fields to `cluster` resource

Derived from GoogleCloudPlatform/magic-modules#8406

…r (#8406)

* Properly handle ABP midnight (hours = 0)

* Add ExpectNonEmptyPlan to test

* Add continuous backup config to alloydb cluster

* add more unit tests

* Adding more tests

* Fix cluster.yaml lint

* Add default value and update cmek test

* Update test to use kms key bootstrapping util

* condense update tests

* Change encryptionType output field to string

* use two different keys

* Only update encryption in CBR

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 21e798f into terraform-google-modules:master Aug 1, 2023
@modular-magician modular-magician deleted the downstream-pr-ed8f2d42602fbc393ca4d5cfbf098b1c8ecd4ce4 branch November 18, 2024 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support AlloyDB continuous backup

1 participant