Skip to content

Merge Beholder into TensorBoard - #613

Merged
jart merged 6 commits into
tensorflow:masterfrom
chrisranderson:master
Oct 7, 2017
Merged

Merge Beholder into TensorBoard#613
jart merged 6 commits into
tensorflow:masterfrom
chrisranderson:master

Conversation

@chrisranderson

Copy link
Copy Markdown

@jart recommended just copying the files over at first without integrating things, so here are the copies. :)

@chrisranderson

Copy link
Copy Markdown
Author

I'll take a look at fixing the paths tomorrow.

@jart

jart commented Oct 4, 2017

Copy link
Copy Markdown
Contributor

Thank you Chris. We have two options:

  1. (Preferred) Update the BUILD files with the new path structure, etc. so that bazel test //tensorboard/... passes. We can't merge unless Travis is green.

  2. Move beholder from tensorboard/plugins to third_party/beholder which side-steps the issue entirely, as that directory is not tested by Travis.

@chrisranderson

chrisranderson commented Oct 4, 2017

Copy link
Copy Markdown
Author

The paths look good, but my tests fail (likely because I'm expecting a certain directory to already exist, I'm thinking). I don't have much free time nowadays - I'm thinking I'll just remove the tests for now (clearly the best solution when your tests fail haha).

@chrisranderson

Copy link
Copy Markdown
Author

@jart The copy-pasted ffmpeg stuff is an issue still, right?

@jart

jart commented Oct 5, 2017

Copy link
Copy Markdown
Contributor

Yes. Is there any chance you could just whip up a quick non-generalized private function to do what it's doing, so that file can be removed?

@jart jart left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you so much for this amazing contribution!

@jart
jart merged commit 2615072 into tensorflow:master Oct 7, 2017
@chrisranderson

Copy link
Copy Markdown
Author

:) Woo hoo! You're welcome. May tons of people learn and benefit from it.

@mholt

mholt commented Oct 7, 2017

Copy link
Copy Markdown

I know our lab will! I'm gonna use this as soon as it's in the regular pip package. Any idea when (or with which release) that will be?

@jart

jart commented Oct 7, 2017

Copy link
Copy Markdown
Contributor

Beholder will most likely be released in TensorBoard 0.5 alongside TensorFlow 1.5. My best guess for when that would happen is January.

I don't expect you to wait that long. So I just registered tb-nightly which will be tf-nightly's doppelganger. Once I'm done putting some polish on Chris' amazing work, I'll write a cron script to update that package, so you can start using it right away (without having to build from source.)

cc: @gunan

@mholt

mholt commented Oct 7, 2017

Copy link
Copy Markdown

Sounds amazing, thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants