Add Levenshtein Distance Check for 'prometheus' Typo in Monitoring Config File#4102
Open
muhammadravi251001 wants to merge 1 commit intotensorflow:masterfrom
Open
Add Levenshtein Distance Check for 'prometheus' Typo in Monitoring Config File#4102muhammadravi251001 wants to merge 1 commit intotensorflow:masterfrom
muhammadravi251001 wants to merge 1 commit intotensorflow:masterfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description:
This PR introduces a check to detect potential typos in the monitoring config file name by calculating the Levenshtein distance between the provided file name and the string
"prometheus". If the distance is 2 or less, a warning will be logged to indicate the possibility of a typo, along with a suggestion to correct the spelling.Background:
I encountered a frustrating bug where a typo in the monitoring config file name led to significant delays in debugging. It took quite a bit of time to realize that the issue stemmed from a simple typographical error when typing
"prometheus".This change is aimed at preventing similar issues in the future by early detection of typos, helping to save time and reduce confusion during troubleshooting.