This repository was archived by the owner on Jul 15, 2025. It is now read-only.
Rename read/write to copyTo/From#19
Merged
karllessard merged 2 commits intotensorflow:mainfrom Feb 20, 2024
Merged
Conversation
Craigacp
suggested changes
Feb 19, 2024
Contributor
Craigacp
left a comment
Craigacp
left a comment
There was a problem hiding this comment.
I think it's worth updating the javadoc with the version that had the old names in, otherwise it looks good.
Craigacp
approved these changes
Feb 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames
NdArray.read(dstBuffer)toNdArray.copyTo(dstBuffer), andNdArray.write(srcBuffer)toNdArray.copyFrom(srcBuffer), to make more obvious the direction of the data flow of these methods.This is somehow related to tensorflow/java#510, though I just modified the signature in
NdArrayand left the one inDataBufferintact, since theread/writemethods of these entities tries to replicate the behaviour of theget/putmethods of the Java NIO buffers.