Repository navigation
fix(xtask): simplify DKG outcome arguments - #7381
Conversation
|
This PR has been marked stale due to 7 days of inactivity. |
| epoch_length: Option<u64>, | ||
| /// Epoch number to query | ||
| #[arg(long)] | ||
| epoch: u64, |
There was a problem hiding this comment.
What if me make this optional and it just gives us latest?
|
Hi @SuperFluffy — your review approval was detected by Voight-Kampff but no live Voight-Kampff agent connection received it, and no push fallback was sent before the approval window closed. Your review did not count toward this PR. You can also try approving the PR directly via CLI with |
Voight-Kampff: dismissing this approval review — it was never confirmed through a Voight-Kampff prompt, so it must not count toward merging this pull request. Re-submit the review and complete the Voight-Kampff prompt if you want this verdict to count.
|
+1 |
![tempo-voight-kampff[bot]](https://avatars.githubusercontent.com/in/3551435?s=60&v=4){kind=small}
There was a problem hiding this comment.
Approving on behalf of @SuperFluffy, who approved this pull request with a +1 comment via Voight-Kampff (head b598a6f5ed85).
GitHub branch protection considers pull request reviews, not +1 comments. Voight-Kampff is recording this approval on the reviewer's behalf so branch protection requirements are met.
decofe
changed the title
Co-authored-by: Derek Cofausper <256792747+decofe@users.noreply.github.com>
3d62e0e to
bb7e64f
Compare
|
+1 |
There was a problem hiding this comment.
Approving on behalf of @SuperFluffy, who approved this pull request with a +1 comment via Voight-Kampff (head bb7e64f05359).
GitHub branch protection considers pull request reviews, not +1 comments. Voight-Kampff is recording this approval on the reviewer's behalf so branch protection requirements are met.
|
cyclops audit fast |
tempoxyz-bot
left a comment
tempoxyz-bot
left a comment
There was a problem hiding this comment.
👁️ Cyclops Review — No actionable findings.
|
+1 |
|
Hi @pepyakin — your review approval was detected by Voight-Kampff but no live Voight-Kampff agent connection received it, so Voight-Kampff sent a push fallback. The push was not approved before the approval window closed. Your review did not count toward this PR. You can also try approving the PR directly via CLI with |
Voight-Kampff: dismissing this approval review — it was never confirmed through a Voight-Kampff prompt, so it must not count toward merging this pull request. Re-submit the review and complete the Voight-Kampff prompt if you want this verdict to count.
There was a problem hiding this comment.
Approving on behalf of @hamdiallam, who approved this pull request with a +1 comment via Voight-Kampff (head bb7e64f05359).
GitHub branch protection considers pull request reviews, not +1 comments. Voight-Kampff is recording this approval on the reviewer's behalf so branch protection requirements are met.
…ows-rollout * origin/main: feat(consensus): ensure certificate tip epoch matches height index (#7671) fix(ci): restore Docker PR build notifications (#7667) fix(consensus): enforce network identity baked into binary/chainspec (#7630) fix(xtask): simplify DKG outcome arguments (#7381) feat(ci): trigger Docker image builds from PR comments (#7655) feat(bench): emit compact workload category metadata (#7663) feat: allow expiring nonce discriminators (#7474) perf(consensus): avoid rehashing locally built proposals (#7650) # Conflicts: # .github/workflows/docker-profiling.yml # .github/workflows/docker.yml
Derive the RPC URL and epoch length from the selected chainspec, with an optional RPC URL override. Make `--epoch` optional: when omitted, print the latest DKG outcome available at the current block, falling back to genesis before the first epoch boundary. Validation: `cargo +nightly fmt --all -- --check` and `cargo test -p tempo-xtask get_dkg_outcome --locked` pass (2 tests). --------- Co-authored-by: Richard Janis Goldschmidt <701177+SuperFluffy@users.noreply.github.com> Co-authored-by: Derek Cofausper <256792747+decofe@users.noreply.github.com> (cherry picked from commit f3faaaa)
Derive the RPC URL and epoch length from the selected chainspec, with an optional RPC URL override. Make `--epoch` optional: when omitted, print the latest DKG outcome available at the current block, falling back to genesis before the first epoch boundary. Validation: `cargo +nightly fmt --all -- --check` and `cargo test -p tempo-xtask get_dkg_outcome --locked` pass (2 tests). --------- Co-authored-by: Richard Janis Goldschmidt <701177+SuperFluffy@users.noreply.github.com> Co-authored-by: Derek Cofausper <256792747+decofe@users.noreply.github.com> (cherry picked from commit f3faaaa)
Derive the RPC URL and epoch length from the selected chainspec, with an optional RPC URL override. Make `--epoch` optional: when omitted, print the latest DKG outcome available at the current block, falling back to genesis before the first epoch boundary. Validation: `cargo +nightly fmt --all -- --check` and `cargo test -p tempo-xtask get_dkg_outcome --locked` pass (2 tests). --------- Co-authored-by: Richard Janis Goldschmidt <701177+SuperFluffy@users.noreply.github.com> Co-authored-by: Derek Cofausper <256792747+decofe@users.noreply.github.com> (cherry picked from commit f3faaaa)
Derive the RPC URL and epoch length from the selected chainspec, with an optional RPC URL override. Make `--epoch` optional: when omitted, print the latest DKG outcome available at the current block, falling back to genesis before the first epoch boundary. Validation: `cargo +nightly fmt --all -- --check` and `cargo test -p tempo-xtask get_dkg_outcome --locked` pass (2 tests). --------- Co-authored-by: Richard Janis Goldschmidt <701177+SuperFluffy@users.noreply.github.com> Co-authored-by: Derek Cofausper <256792747+decofe@users.noreply.github.com> (cherry picked from commit f3faaaa)
Simplify DKG outcome arguments for v1.15.0 by deriving defaults from the selected chainspec and allowing the latest available epoch. Stack position 2 of 4; source commit from [#7742](#7742): [68feaa5](68feaa5), originally [#7381](#7381). Merge after [#7794](#7794); retarget to `release/v1.15.0` once its predecessor is merged. Validation: one commit per PR and a clean `git diff --check`. The full `cargo deny --all-features --locked check` passed locally using cargo-deny 0.20.2. The only additional change beyond the original stack is the targeted lockfile update for RUSTSEC-2026-0292. Fresh CI is running. Prompted by: @hamdiallam Co-authored-by: Hamdi Allam <10552045+hamdiallam@users.noreply.github.com> Co-authored-by: Richard Janis Goldschmidt <701177+SuperFluffy@users.noreply.github.com>
4 participants
Derive the RPC URL and epoch length from the selected chainspec, with an optional RPC URL override. Make
--epochoptional: when omitted, print the latest DKG outcome available at the current block, falling back to genesis before the first epoch boundary.Validation:
cargo +nightly fmt --all -- --checkandcargo test -p tempo-xtask get_dkg_outcome --lockedpass (2 tests).