Add test utility to create Nexus endpoint#1279
Open
Quinn-With-Two-Ns wants to merge 2 commits intotemporalio:mainfrom
Open
Add test utility to create Nexus endpoint#1279Quinn-With-Two-Ns wants to merge 2 commits intotemporalio:mainfrom
Quinn-With-Two-Ns wants to merge 2 commits intotemporalio:mainfrom
Conversation
THardy98
approved these changes
Feb 3, 2026
Contributor
|
It does have typechecking issues however. |
5693a43 to
9ba31d0
Compare
9ba31d0 to
9d85501
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add test utility to create Nexus endpoint. This matches what we have in Java and Dotnet
Note
Low Risk
Mostly adds a small testing API surface and refactors tests to call it; minimal production impact aside from depending on operator-service Nexus RPCs being available in the test environment.
Overview
Adds
WorkflowEnvironment.create_nexus_endpoint()andWorkflowEnvironment.delete_nexus_endpoint()to create/delete Nexus endpoints via the operator service, returning the createdEndpoint.Updates the test suite to use the new environment helper everywhere Nexus endpoints are needed, and removes the now-redundant
tests.helpers.nexus.create_nexus_endpointutility (leaving onlymake_nexus_endpoint_name).Written by Cursor Bugbot for commit 9d85501. This will update automatically on new commits. Configure here.