Skip to content

Upgrade google.golang.org/grpc to 1.83.2 in both modules - #357

Merged
picatz merged 1 commit into
mainfrom
fix/grpc-fixable-high-both-modules
Sep 11, 2026
Merged

picatz merged 1 commit into
mainfrom
fix/grpc-fixable-high-both-modules

Conversation

@picatz

@picatz picatz commented Sep 11, 2026 •

Copy link
Copy Markdown
Collaborator

main's scheduled Security workflow has been red since 2026-09-07: google.golang.org/grpc 1.82.1 carries two fixable high-severity advisories (CVE-2026-84304, CVE-2026-84445), and the ci-block-fixable-high rule in policy/ci/security-gate.yaml denies any fixable high. Every PR opened against main inherits that failure until the dependency moves.

Dependabot tried and could not land it. #356 bumps the root module and #355 bumps examples/sandbox-plugins/vz, and each branch still sees 1.82.1 in the other module, so both fail the same gate. The two modules have to move together, which is what this change does. Dependabot closes its own PRs once the dependency is current on main.

The upgrade was applied with Deputy's own remediation flow rather than by hand, as a dogfood of the plan, review, apply loop the fix docs describe:

deputy fix --ignore-unfixed --format json > plan.json
jq '.commands |= map(select(.package == "google.golang.org/grpc" or .command == "go mod tidy"))' plan.json > plan-grpc.json
deputy fix --plan plan-grpc.json --apply .

The first plan targeted 1.83.1, which sits inside CVE-2026-84445's second affected range [1.83.0, 1.83.2), so the gate still denied after apply. A second plan from the patched tree targeted 1.83.2 and cleared it. That planner gap is #358; the upgrade here is correct regardless.

grpc 1.83.2 raises its minimums on go.opentelemetry.io/otel (1.44.0) and google.golang.org/genproto, which accounts for the rest of the go.mod churn. The otel move also closes CVE-2026-41178.

Verified: deputy scan --policy policy/ci/security-gate.yaml exits 0 on this tree (exit 1 on main); go build ./... && go vet ./... && go test ./... pass in the root module; examples/sandbox-plugins/vz builds and vets locally on macOS, since CI does not build that module.

🤖 Generated with Claude Code

main's scheduled Security workflow has failed since 2026-09-07 because
google.golang.org/grpc 1.82.1 carries two fixable high-severity
advisories (CVE-2026-84304, CVE-2026-84445) and the CI gate denies
fixable highs. Dependabot opened one bump per go.mod (#355, #356), so
each branch still saw the old version in the other module and failed
the same gate.

This upgrades the root module and examples/sandbox-plugins/vz together,
applied with Deputy's own remediation flow: `deputy fix --format json`,
the plan filtered to the grpc steps, then `deputy fix --plan --apply`.
The first plan targeted 1.83.1, which still sits inside
CVE-2026-84445's second affected range [1.83.0, 1.83.2); a second plan
from the patched tree moved it to 1.83.2. That planner gap is filed
separately.

grpc 1.83.2 raises its otel and genproto minimums, which is what the
remaining go.mod churn is.

`deputy scan --policy policy/ci/security-gate.yaml` now exits 0, and
`go build ./... && go vet ./... && go test ./...` pass in both modules.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 11, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-11T20:18:07.325329Z 6e53baf PR opened
🔒 Security Review ✅ Completed 2026-09-11T20:19:27.313469Z 6e53baf PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown

Deputy Dependency Diff

main → fix/grpc-fixable-high-both-modules

17 dependency changes (17 upgraded) · ✅ no new vulnerabilities · ✅ policies passed

Dependency changes

Package Version Licenses
↑ go.opentelemetry.io/otel 1.43.0 → 1.44.0 Apache-2.0, BSD-3-Clause direct
↑ go.opentelemetry.io/otel/metric 1.43.0 → 1.44.0 Apache-2.0, BSD-3-Clause direct
↑ go.opentelemetry.io/otel/sdk 1.43.0 → 1.44.0 Apache-2.0, BSD-3-Clause direct
↑ go.opentelemetry.io/otel/sdk/metric 1.43.0 → 1.44.0 Apache-2.0, BSD-3-Clause direct
↑ go.opentelemetry.io/otel/trace 1.43.0 → 1.44.0 Apache-2.0, BSD-3-Clause direct
↑ golang.org/x/crypto 0.53.0 → 0.55.0 BSD-3-Clause direct
↑ golang.org/x/mod 0.37.0 → 0.38.0 BSD-3-Clause direct
↑ golang.org/x/net 0.56.0 → 0.58.0 BSD-3-Clause direct
↑ golang.org/x/sync 0.21.0 → 0.22.0 BSD-3-Clause direct
↑ golang.org/x/sys 0.46.0 → 0.47.0 BSD-3-Clause direct
↑ golang.org/x/telemetry 0.0.0-20260625142307-59b4966ccb57 → 0.0.0-20260708182218-49f421fb7959 BSD-3-Clause direct
↑ golang.org/x/term 0.44.0 → 0.45.0 BSD-3-Clause direct
↑ golang.org/x/text 0.39.0 → 0.41.0 BSD-3-Clause direct
↑ golang.org/x/tools 0.47.0 → 0.48.0 BSD-3-Clause direct
↑ google.golang.org/genproto/googleapis/api 0.0.0-20260511170946-3700d4141b60 → 0.0.0-20260526163538-3dc84a4a5aaa Apache-2.0 indirect
↑ google.golang.org/genproto/googleapis/rpc 0.0.0-20260511170946-3700d4141b60 → 0.0.0-20260526163538-3dc84a4a5aaa Apache-2.0 indirect
↑ google.golang.org/grpc 1.82.1 → 1.83.2 Apache-2.0 direct
20 pre-existing vulnerabilities not introduced by this change
ID Severity Package Fixed in
GO-2026-5841 UNKNOWN github.com/klauspost/compress @ v1.18.6 1.18.7
GHSA-7236-3392-c5c6 MEDIUM github.com/moby/buildkit @ v0.30.0 0.31.1
GHSA-72x6-4j93-7w86 LOW github.com/moby/buildkit @ v0.30.0 0.31.1
GO-2026-6255 MEDIUM github.com/moby/buildkit @ v0.30.0 0.31.1
GO-2026-6256 LOW github.com/moby/buildkit @ v0.30.0 0.31.1
GO-2026-4970 UNKNOWN stdlib @ v1.26.4 1.25.12, 1.26.5, 1.27.0-rc.2
GO-2026-5026 UNKNOWN stdlib @ v1.26.4 1.25.13, 1.26.6, 1.27.0-rc.3
GO-2026-5856 UNKNOWN stdlib @ v1.26.4 1.25.12, 1.26.5, 1.27.0-rc.2
GO-2026-5942 UNKNOWN stdlib @ v1.26.4 1.26.6, 1.27.0-rc.3
GO-2026-5972 UNKNOWN stdlib @ v1.26.4 1.25.13, 1.26.6, 1.27.0-rc.3
GO-2026-6088 UNKNOWN stdlib @ v1.26.4 1.25.13, 1.26.6, 1.27.0-rc.3
GO-2026-6089 UNKNOWN stdlib @ v1.26.4 1.27.0-rc.3, 1.25.13, 1.26.6
GO-2026-6090 UNKNOWN stdlib @ v1.26.4 1.27.0-rc.3, 1.25.13, 1.26.6
GO-2026-6091 UNKNOWN stdlib @ v1.26.4 1.26.6, 1.27.0-rc.3, 1.25.13
GO-2026-6218 UNKNOWN stdlib @ v1.26.4 1.27.0-rc.3, 1.25.13, 1.26.6
GO-2026-5932 UNKNOWN golang.org/x/crypto @ v0.55.0
GO-2026-6354 UNKNOWN golang.org/x/crypto @ v0.55.0 0.56.0
GO-2026-6355 UNKNOWN golang.org/x/crypto @ v0.55.0 0.56.0
GO-2026-6179 UNKNOWN golang.org/x/mod @ v0.38.0 0.40.0
GO-2026-6180 UNKNOWN golang.org/x/mod @ v0.38.0 0.40.0

Policy evaluation

✅ 1 policy file evaluated, all rules passed

Generated by Deputy

@picatz
picatz merged commit c125352 into main Sep 11, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants