Conversation
dplyukhin
commented
Jul 29, 2026
|
|
||
| NEXUS_SCHEMA_ROOT := $(PROTO_ROOT)/nexus | ||
| NEXUS_PROTO_OUT := workflowservice/v1/workflowservicenexus | ||
| NEXUS_WIT_OUT := workflowservice/v1/systemnexus |
Contributor
Author
There was a problem hiding this comment.
Does anyone have opinions on where we should put the WIT files?
dplyukhin
commented
Jul 29, 2026
Comment on lines
+59
to
+64
| .PHONY: system-nexus | ||
| system-nexus: | ||
| printf $(COLOR) "Update system-nexus WIT files..." | ||
| rm -rf $(NEXUS_WIT_OUT) | ||
| mkdir -p $(NEXUS_WIT_OUT) | ||
| cp -R $(NEXUS_SCHEMA_ROOT)/workflow-service.wit $(NEXUS_SCHEMA_ROOT)/deps $(NEXUS_WIT_OUT)/ |
Contributor
Author
There was a problem hiding this comment.
@tconley1428 Based on your plans for future WIT stuff, does this make sense for how to lay things out in the api-go directory? i.e., we copy XXX-service.wit into the XXXservice/v1/systemnexus directory, along with the entirety of deps/?
Contributor
There was a problem hiding this comment.
I don't really have any opinion on location here.
dplyukhin
marked this pull request as ready for review
July 29, 2026 16:17
yuandrew
approved these changes
Jul 31, 2026
yuandrew
left a comment
yuandrew
left a comment
Contributor
There was a problem hiding this comment.
Looks reasonable to me, @Quinn-With-Two-Ns, not sure if you wanna also take a peak
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Updated Makefile to copy WIT service definitions from temporal-api
Why?
So the Go SDK can use the files to generate system nexus APIs like
SignalWithStartWorkflow.How did you test it?
Tested locally
Potential risks