Repository navigation
Sdbv rbac changes - #267
Merged
Merged
Conversation
Field validation changes
User update issue
Issue PS-4386: Added kafka Service and Push Create User Event
Update kadfka module
verify Otp Changes
Send otp on mail after login
|
Caution Review failedThe pull request is closed. WalkthroughThis update introduces Kafka integration across the application, adding a Kafka service, configuration, and module, and wiring Kafka event publishing into user lifecycle operations. The main application and user modules are updated to import the Kafka module. The Postgres user service now publishes Kafka events for user creation, update, and deletion, and includes a new method for sending OTP emails. Tenant and field attribute logic is simplified by removing tenant-specific attribute selection. Validation constraints on cohort member DTOs are relaxed to allow larger arrays. A custom OTP validator is implemented to support dynamic OTP lengths. The Tenant entity gains a new JSON column for content filtering. Changes
Sequence Diagram(s)sequenceDiagram
participant API_Client
participant PostgresUserService
participant KafkaService
participant Database
API_Client->>PostgresUserService: createUser/updateUser/deleteUserById
PostgresUserService->>Database: Perform user operation
Database-->>PostgresUserService: Result
PostgresUserService-->>API_Client: Send HTTP response
Note right of PostgresUserService: After response, asynchronously:
PostgresUserService->>KafkaService: publishUserEvent(eventType, userData, userId)
KafkaService->>Kafka: Produce event message (if enabled)
sequenceDiagram
participant UserService
participant KafkaService
participant Kafka
UserService->>KafkaService: publishUserEvent(eventType, userData, userId)
KafkaService->>Kafka: Send message to topic (if enabled)
Kafka-->>KafkaService: Ack/Error
KafkaService-->>UserService: Log result
sequenceDiagram
participant User
participant OtpVerifyDTO
User->>OtpVerifyDTO: Submit OTP
OtpVerifyDTO->>IsValidOtp: Validate OTP (length from env)
IsValidOtp-->>OtpVerifyDTO: Pass/Fail
OtpVerifyDTO-->>User: Validation result
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (14)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Improvements
Chores