Create control task for 'pre-survey' and clean up stale chat channel - #455
Merged
Conversation
gpaoloni
approved these changes
Jun 1, 2023
gpaoloni
left a comment
gpaoloni
left a comment
Collaborator
There was a problem hiding this comment.
Looks great, thanks! Only changes I suggest are related to cleaning the debug logs.
Comment on lines
+99
to
+100
| const cleanupType = taskAttributes.isChatbotCaptureControl ? 'pre-survey' : 'post-survey'; | ||
| console.log(`Handling clean up ${cleanupType}...`); |
Collaborator
There was a problem hiding this comment.
Let's remove this one before merging, feels like unnecessary noise.
| }, | ||
| }); | ||
| }, | ||
| ].map((func) => func()), |
Collaborator
There was a problem hiding this comment.
I know this was handy for debugging, but it's actually easier to read if this are Promises (rather than functions that return promises and then map the call to each). Can you revert the change?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
isChatCaptureControlfilter attribute to 'Survey' workflowisChatCaptureControlcompletedassignment stateChecklist
Related Issues
Fixes # 1789
Verification steps
Live logson.Move control task to complete state.