CHI-3711: POC for voice and sms E2E tests - CI only by stephenhand · Pull Request #4547 · techmatters/flex-plugins

stephenhand · 2026-07-22T12:22:53Z

Description

This creates a POC for testing SMS and Voice calls with E2E tests

They are only tested as CI tests running locally, not for production in lambdas
There's probably a few hardcoded bits that need tidying up when productionising
We send all the test tasks to the same queue - webchat, SMS and voice, is this an issue?
We need a task to clean up conversations for the SMS tests to run after a failure. Should this be necessary?

Checklist

Corresponding issue has been opened
New tests added
[n/a] Feature flags added
[n/a] Strings are localized
Tested for chat contacts
Tested for call contacts

Other Related Issues

None

Verification steps

AFTER YOU MERGE

Cut a release tag using the Github workflow. Wait for it to complete and notify in the #aselo-deploys Slack channel.
Comment on the ticket with the release tag version AND any additional instructions required to configure an environment to test the changes.
Only then move the ticket into the QA column in JIRA

You are responsible for ensuring the above steps are completed. If you move a ticket into QA without advising what version to test, the QA team will assume the latest tag has the changes. If it does not, the following confusion is on you! :-P

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Co-authored-by: stephenhand <1694716+stephenhand@users.noreply.github.com>

…nt/AsyncIterable pattern Co-authored-by: stephenhand <1694716+stephenhand@users.noreply.github.com>

…basic-sms-test-methods

…methods

- Add SMS channel to twilio-iac/helplines/e2e/development.hcl using the messaging-lex-v3-blocking-lambda.tftpl template (same as aselo_webchat) and an empty contact_identity (conversations address managed separately) - Create twilio-iac/helplines/e2e/files/additional.configure.tf that uses a Twilio data source to look up the only phone number attached to the account at apply time and creates the SMS conversations address linked to the SMS studio flow - Guard twilio_conversations_configuration_addresses_v1 in channels/v1/main.tf so channels with an empty contact_identity skip automatic address creation (allowing helpline-specific additional.tf to manage it instead) Co-authored-by: stephenhand <1694716+stephenhand@users.noreply.github.com>

Co-authored-by: stephenhand <1694716+stephenhand@users.noreply.github.com>

…basic-sms-test-methods

- Replace dynamic phone number lookup with hardcoded +12607821891 in both development.hcl and additional.configure.tf - Remove data source that previously scraped the phone number from the Twilio account - Set contact_identity to the hardcoded phone number in the SMS channel configuration Co-authored-by: stephenhand <1694716+stephenhand@users.noreply.github.com>

The twilio-iac/terraform-modules/channels/v1/main.tf module now automatically creates the SMS conversations address since contact_identity is no longer empty. The separate additional.configure.tf file is no longer needed. Co-authored-by: stephenhand <1694716+stephenhand@users.noreply.github.com>

- Add voice channel using voice-no-chatbot-operating-hours-blocking-lambda template - Use the same phone number (+12607821891) as the SMS channel - Include voice_ivr_greeting_message, voice_ivr_blocked_message, and voice_ivr_language - Follows established patterns used in other helplines for voice configurations Co-authored-by: stephenhand <1694716+stephenhand@users.noreply.github.com>

… CHI-3711-voice_test_poc

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Co-authored-by: stephenhand <1694716+stephenhand@users.noreply.github.com>

…nt/AsyncIterable pattern Co-authored-by: stephenhand <1694716+stephenhand@users.noreply.github.com>

- Add SMS channel to twilio-iac/helplines/e2e/development.hcl using the messaging-lex-v3-blocking-lambda.tftpl template (same as aselo_webchat) and an empty contact_identity (conversations address managed separately) - Create twilio-iac/helplines/e2e/files/additional.configure.tf that uses a Twilio data source to look up the only phone number attached to the account at apply time and creates the SMS conversations address linked to the SMS studio flow - Guard twilio_conversations_configuration_addresses_v1 in channels/v1/main.tf so channels with an empty contact_identity skip automatic address creation (allowing helpline-specific additional.tf to manage it instead) Co-authored-by: stephenhand <1694716+stephenhand@users.noreply.github.com>

Co-authored-by: stephenhand <1694716+stephenhand@users.noreply.github.com>

- Add voice channel using voice-no-chatbot-operating-hours-blocking-lambda template - Use the same phone number (+12607821891) as the SMS channel - Include voice_ivr_greeting_message, voice_ivr_blocked_message, and voice_ivr_language - Follows established patterns used in other helplines for voice configurations Co-authored-by: stephenhand <1694716+stephenhand@users.noreply.github.com>

…I-3711-voice_test_poc # Conflicts: # e2e-tests/tests/offlineContact.spec.ts

…methods

…mbda

… CHI-3711-voice_test_poc

Copilot

Pull request overview

Adds WIP support for voice end-to-end testing by extending Twilio TaskRouter/IaC configuration, adding a new voice filtering lambda, and expanding Playwright E2E utilities/tests to cover voice and SMS via Conversations.

Changes:

Add a new TaskRouter workflow filter + queue for “Voice E2E Test” routing.
Introduce voice/filterCountryOrVoIP account-scoped lambda (with unit tests) and route wiring.
Add/adjust Playwright E2E helpers and specs for voice calling, SMS Conversations flow, and more reusable contact form filling.

Reviewed changes

Copilot reviewed 21 out of 21 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
twilio-iac/helplines/templates/workflows/master.tftpl	Adds a new “Voice E2E Test” routing filter targeting a new queue
twilio-iac/helplines/e2e/development.hcl	Expands E2E routing filter expression to include voice and SMS
twilio-iac/helplines/e2e/common.hcl	Adds `e2e_test_voice` task queue for the E2E helpline config
twilio-iac/helplines/defaults.hcl	Adds `e2e_test_voice` task queue to global defaults
lambdas/account-scoped/tests/unit/voice/filterCountryOrVoIP.test.ts	Unit tests for the new voice filtering handler
lambdas/account-scoped/src/voice/filterCountryOrVoIP.ts	New handler to block non-US and VoIP/blocked-carrier callers via Twilio Lookups
lambdas/account-scoped/src/router.ts	Wires the new `voice/filterCountryOrVoIP` route into the router
e2e-tests/workerStatus.ts	Improves worker status-setting robustness and logging
e2e-tests/twilio/voice.ts	Adds helper to initiate a voice call into the service under test
e2e-tests/twilio/sms.ts	Reworks SMS E2E to use Twilio Conversations (stateful conversation SID)
e2e-tests/twilio/channels.ts	Adds cleanup utilities for SMS conversations and migrates chat cleanup to Conversations APIs
e2e-tests/tests/voice.spec.ts	New Playwright voice E2E spec that accepts a task and submits a contact form
e2e-tests/tests/sms.spec.ts	Updates SMS spec to use new contact-form helper + conversation cleanup
e2e-tests/tests/offlineContact.spec.ts	Refactors offline-contact spec to reuse form content helpers
e2e-tests/tests/aseloWebchat.spec.ts	Refactors webchat spec to reuse contact-form helper
e2e-tests/playwright.config.ts	Adds fake media-stream args for local runs and deduplicates args setup
e2e-tests/package.json	Updates scripts for conversation cleanup and local retry behavior
e2e-tests/formContentsByHelpline.ts	Adjusts form content and introduces an “empty form” variant map
e2e-tests/deleteConversations.ts	Updates cleanup script to delete both chat and SMS conversations
e2e-tests/contactForm.ts	Adds `fillWithContent` helper to reuse a consistent tab-filling sequence

+       "filter_friendly_name": "Voice E2E Test",
+       "expression": "channelType=='voice' AND name=='+12064083885'",
+       "targets": [
+         {
+           "expression": "(worker.waitingOfflineContact != true AND ((task.channelType == 'voice' AND worker.channel.chat.assigned_tasks == 0) OR (task.channelType != 'voice' AND worker.channel.voice.assigned_tasks == 0)) AND ((task.transferTargetType == 'worker' AND task.targetSid == worker.sid) OR (task.transferTargetType != 'worker' AND worker.sid != task.ignoreAgent))) OR (worker.waitingOfflineContact == true AND task.targetSid == worker.sid AND task.isContactlessTask == true)",


+export const makeCallToService = async () => {
+  const clientAccountSid = getConfigValue('clientTwilioAccountSid') as string;
+  const authToken = getConfigValue('clientTwilioAuthToken') as string;
+  const from = getConfigValue('clientSmsPhoneNumber') as string;


+        participants.some((participant) => {
+          return (
+            participant.messagingBinding?.address === fromNumber &&
+            participant.messagingBinding?.proxy_address === toNumber
+          );
+        })


 // Tracks the start of the current SMS test session so we only check messages received after this time
 let sessionStartTime: Date | undefined;

+let clientConversationSid: string;


+    const helpline = getConfigValue('helplineShortCode') as keyof typeof formContentsByHelpline;
+    const formContent = formContentsByHelplineForEmptyForm[helpline];



Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

…I-3711-voice_test_poc

stephenhand · 2026-08-10T14:09:03Z

@gpaoloni ?

gpaoloni

LGTM 🚀
Do we have documentation on how to setup/configure the e2e tests for accounts somewhere? If so, could that be linked somewhere in the 2e README?

gpaoloni · 2026-08-21T02:18:02Z

+  // Delete conversations from service Twilio account
+  await deleteSmsConversationFromOneEnd(
+    serviceAccountSid,
+    serviceAuthToken,
+    senderSmsNumber,
+    serviceSmsNumber,
+  );
+
+  // Delete conversations from sender Twilio account
+  await deleteSmsConversationFromOneEnd(
+    senderAccountSid,
+    senderAuthToken,
+    serviceSmsNumber,
+    senderSmsNumber,
+  );


About this, I understand the "client account" is the one we use to send SMS messages. I see that is defined via config but in practice what account will be used for this?

I'm just using AS_DEV for now

stephenhand and others added 30 commits July 15, 2026 14:37

WIP add config and basic SMS test methods

dc009dd

Potential fix for pull request finding

396ff36

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Potential fix for pull request finding

88a9075

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

fix: use chat api for e2e channel cleanup lookup

30f7c09

Co-authored-by: stephenhand <1694716+stephenhand@users.noreply.github.com>

Initial plan

859eca5

feat: add SMS E2E test mirroring webchat test with shared ChatStateme…

a3f6730

…nt/AsyncIterable pattern Co-authored-by: stephenhand <1694716+stephenhand@users.noreply.github.com>

Licence headers

5b6c919

Merge branch 'CHI-3711-sms_e2e_test' into copilot/wip-add-config-and-…

c0ee276

…basic-sms-test-methods

Merge branch 'master' into copilot/wip-add-config-and-basic-sms-test-…

6cfb45f

…methods

Merge branch 'master' into copilot/wip-add-config-and-basic-sms-test-…

bde9a95

…methods

fix: use consistent SMS capitalization in friendly_name

e036e2c

Co-authored-by: stephenhand <1694716+stephenhand@users.noreply.github.com>

Merge branch 'master' into CHI-3711-sms_e2e_test

8d7e138

Merge branch 'CHI-3711-sms_e2e_test' into copilot/wip-add-config-and-…

36c8d90

…basic-sms-test-methods

WIP voice testing

cc25f5d

Merge branch 'copilot/wip-add-config-and-basic-sms-test-methods' into…

d594f50

… CHI-3711-voice_test_poc

First passing voice E2E test

9a0cbe8

Licence

9c75bcc

WIP add config and basic SMS test methods

cfdb3b2

Potential fix for pull request finding

c7e8ebd

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Potential fix for pull request finding

78fe83e

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

fix: use chat api for e2e channel cleanup lookup

aacc4b9

Co-authored-by: stephenhand <1694716+stephenhand@users.noreply.github.com>

Initial plan

62bc1fe

feat: add SMS E2E test mirroring webchat test with shared ChatStateme…

dcba977

…nt/AsyncIterable pattern Co-authored-by: stephenhand <1694716+stephenhand@users.noreply.github.com>

Licence headers

dece3bc

fix: use consistent SMS capitalization in friendly_name

49b86ec

Co-authored-by: stephenhand <1694716+stephenhand@users.noreply.github.com>

Copilot AI and others added 13 commits July 22, 2026 23:44

First passing voice E2E test

f1144a1

Licence

64730de

Fix offlie contact e2e test

4547284

Merge remote-tracking branch 'origin/CHI-3711-voice_test_poc' into CH…

6c571c7

…I-3711-voice_test_poc # Conflicts: # e2e-tests/tests/offlineContact.spec.ts

Fix offlie contact e2e test

465730d

Linter

cf32d57

Merge branch 'master' into copilot/wip-add-config-and-basic-sms-test-…

1a324b0

…methods

Extra assertion in E2E tests

d4c6192

Fake sound input for all E2E browsers, not just those running in a la…

8cc9d5e

…mbda

Revert local change

e37b2a8

Linter

42daf15

Merge branch 'copilot/wip-add-config-and-basic-sms-test-methods' into…

5b95060

… CHI-3711-voice_test_poc

stephenhand marked this pull request as ready for review July 23, 2026 12:49

Copilot AI review requested due to automatic review settings July 23, 2026 12:49

Copilot started reviewing on behalf of stephenhand July 23, 2026 12:50 View session

stephenhand requested a review from gpaoloni July 23, 2026 12:55

Copilot AI reviewed Jul 23, 2026

View reviewed changes

stephenhand changed the base branch from copilot/wip-add-config-and-basic-sms-test-methods to master July 23, 2026 15:20

stephenhand and others added 5 commits July 23, 2026 16:23

Apply suggestions from code review

5fb2a6f

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Remove E2E voice queue

02ebb61

Merge remote-tracking branch 'origin/CHI-3711-voice_test_poc' into CH…

32a32d2

…I-3711-voice_test_poc

Merge branch 'master' into CHI-3711-voice_test_poc

8920634

Revert unused update

8924aba

stephenhand changed the title ~~WIP voice testing~~ CHI-3711: POC for voice and sms E2E tests - CI only Jul 23, 2026

Merge branch 'master' into CHI-3711-voice_test_poc

b6fd887

gpaoloni approved these changes Aug 21, 2026

View reviewed changes

stephenhand merged commit 5ec7363 into master Aug 21, 2026
23 checks passed

stephenhand deleted the CHI-3711-voice_test_poc branch August 21, 2026 10:42

Navigation Menu

Uh oh!

CHI-3711: POC for voice and sms E2E tests - CI only - #4547

CHI-3711: POC for voice and sms E2E tests - CI only#4547
stephenhand merged 52 commits into
masterfrom
CHI-3711-voice_test_poc

stephenhand commented Jul 22, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

stephenhand commented Aug 10, 2026

Uh oh!

gpaoloni left a comment

Uh oh!

gpaoloni Aug 21, 2026

Uh oh!

stephenhand Aug 21, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		const helpline = getConfigValue('helplineShortCode') as keyof typeof formContentsByHelpline;
		const formContent = formContentsByHelplineForEmptyForm[helpline];

Uh oh!

Conversation

stephenhand commented Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Other Related Issues

Verification steps

AFTER YOU MERGE

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

stephenhand commented Aug 10, 2026

Uh oh!

gpaoloni left a comment

Choose a reason for hiding this comment

Uh oh!

gpaoloni Aug 21, 2026

Choose a reason for hiding this comment

Uh oh!

stephenhand Aug 21, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

stephenhand commented Jul 22, 2026 •

edited

Loading