Repository navigation
fix(store): error instead of panic on invalid rid - #3157
Conversation
Package Changes Through 6883732There are 23 changes which include dialog-js with minor, dialog with minor, log with minor, log-js with minor, localhost with patch, barcode-scanner with patch, barcode-scanner-js with patch, deep-link with patch, deep-link-js with patch, fs with patch, fs-js with patch, http with patch, http-js with patch, nfc with patch, nfc-js with patch, store with patch, store-js with patch, updater with minor, updater-js with minor, upload with minor, upload-js with minor, websocket with patch, websocket-js with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
FabianLars
left a comment
There was a problem hiding this comment.
#NeverUnwrap(ExceptOnMutexes)
Option 1 of #3145 (comment)
Fix #3145
Compared to #3156, this is lesser involved, we simply return an error if the resource table gets modified from elsewhere, and if the user holds onto a store after either calling
Store.closeorStore::close_resource, there could be more than 1 store on a single path in theory. We could always go with this one first though