Skip to content

Resolve boolean in isAvailable to agree with TypeScript API - #3101

Merged
FabianLars merged 8 commits into
tauri-apps:v2from
bclarke123:nfc-function-signature
Nov 13, 2025
Merged

FabianLars merged 8 commits into
tauri-apps:v2from
bclarke123:nfc-function-signature

Conversation

@bclarke123

@bclarke123 bclarke123 commented Nov 12, 2025 •

Copy link
Copy Markdown
Contributor

Description: Updates native plugins for Android / iOS to resolve a simple boolean in the isAvailable() functions of the NFC plugin

Fixes: #2830

Tested: iOS / Android simulators; iPhone 8, Pixel 10

@bclarke123
bclarke123 requested a review from a team as a code owner November 12, 2025 17:54
@FabianLars

Copy link
Copy Markdown
Member

Thanks for the PR! could you also add a small changefile please? (check .changes dir for examples)

@github-actions

github-actions Bot commented Nov 12, 2025 •

Copy link
Copy Markdown
Contributor

Package Changes Through 5882596

There are 8 changes which include log with minor, log-js with minor, nfc with minor, nfc-js with minor, updater with minor, updater-js with minor, upload with minor, upload-js with minor

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
api-example 2.0.38 2.0.39
api-example-js 2.0.34 2.0.35
log 2.7.1 2.8.0
log-js 2.7.1 2.8.0
nfc 2.3.3 2.4.0
nfc-js 2.3.3 2.4.0
updater 2.9.0 2.10.0
updater-js 2.9.0 2.10.0
upload 2.3.2 2.4.0
upload-js 2.3.2 2.4.0

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@FabianLars

Copy link
Copy Markdown
Member

Do it the other way to maintain expected functionality in Rust code

i mean, the rust code could be updated as well, i think it should support this as well no?

@bclarke123

Copy link
Copy Markdown
Contributor Author

Do it the other way to maintain expected functionality in Rust code

i mean, the rust code could be updated as well, i think it should support this as well no?

It absolutely can, after re-reading the original issue where it was suggested to update the TypeScript, I looked at that approach and it made for fewer changes, and only impacts TS usage. The original approach would have affected every isAvailable call in every downstream project.

@FabianLars
FabianLars merged commit b4348ce into tauri-apps:v2 Nov 13, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

wrong ts signature for NFC isAvailable return type

2 participants