fix: type hint when whatchfiles library is not installed#548
Merged
s3rius merged 1 commit intotaskiq-python:masterfrom Nov 25, 2025
Merged
fix: type hint when whatchfiles library is not installed#548s3rius merged 1 commit intotaskiq-python:masterfrom
s3rius merged 1 commit intotaskiq-python:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a type-checking issue by changing the type hint for the observer parameter from the modern PEP 604 union syntax (Observer | None) to the old-style Optional[Observer]. This change is specifically made for a conditionally defined type (Observer) that can be None when the optional watchdog dependency is not installed, which appears to cause issues with type checkers.
- Changed
observerparameter type hint to useOptional[Observer]instead ofObserver | None - Added
Optionalimport fromtypingmodule - Added
# noqa: UP045to suppress ruff's modernization suggestion
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
s3rius
reviewed
Nov 24, 2025
e2090a6 to
ecec5e4
Compare
s3rius
approved these changes
Nov 25, 2025
Optional for case with Observer type hint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
taskiq scheduler --helpcalled withoutwatchdoginstalled, this issue occur:This pull request fixes it by using old-style type hint
Optional