fix: recursive dict in labels during schedule discovery in LabelScheduleSource#520
Merged
s3rius merged 2 commits intotaskiq-python:masterfrom Oct 23, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes two issues in the LabelScheduleSource class related to schedule discovery: preventing recursive dictionary structures in task labels when labels are passed within schedules, and preserving user-provided schedule_id values instead of always overwriting them with random UUIDs. The fix involves deep copying task labels and excluding the schedule key to avoid recursion, and respecting user-provided schedule IDs.
Key changes:
- Modified label handling in
LabelScheduleSource.startup()to deep copy task labels and remove theschedulekey before merging - Updated schedule ID generation to use user-provided
schedule_idwhen available - Removed duplicate test file and enhanced existing tests with new test cases
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| taskiq/schedule_sources/label_based.py | Fixed recursive label structure by deep copying and filtering task labels, and preserved user-provided schedule IDs |
| tests/scheduler/test_label_based_sched.py | Added test cases for labels inside schedules and custom schedule IDs, plus verification that original task labels remain unchanged |
| tests/schedule_sources/test_label_based.py | Deleted duplicate test file |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
danfimov
commented
Oct 22, 2025
8547085 to
db06ba1
Compare
s3rius
previously approved these changes
Oct 22, 2025
…rce usage example
s3rius
approved these changes
Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed issues:
labelsare passed insideschedule, theScheduledTask.labelsfield contained a recursive structure - discussion;schedule_idinsideschedule, it was always replaced with a random UUID.Also deleted duplicated tests:
tests/schedule_sources/test_label_based.pyare literally the same as intests/scheduler/test_label_based_sched.py.