Adding Flush() to flush serial port I/O buffers#22
Merged
Conversation
madhurjain
commented
Mar 13, 2015
madhurjain
commented
Contributor
- Current implementation will flush both Input and Output buffers
- Added Flush to Windows calling PurgeComm()
- Added Flush to POSIX calling tcflush()
- Added Flush to Linux using syscall IOCTL with TCFLSH
- Tested on Windows, POSIX and Linux environment
- Current implementation will flush both Input and Output buffers - Added Flush to Windows calling PurgeComm() - Added Flush to POSIX calling tcflush() - Added Flush to Linux using syscall IOCTL with TCFLSH - Tested on Windows, POSIX and Linux environment
Owner
There was a problem hiding this comment.
Why not just use p.f.Fd() here? Right now it seems like Port would have redundant information with both File and fd.
Owner
|
Overall it looks good. It would be great to get some godoc comments about Flush() as well. I think the linux version is what godoc would grab. |
- Removed reduntant File Descriptor field stored in Port structure for Linux and POSIX implementations
tarm
added a commit
that referenced
this pull request
Mar 17, 2015
Adding Flush() to flush serial port I/O buffers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.