Skip to content

fix(server): preserve root agent activity #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tarik02 merged 1 commit into from
Jul 30, 2026
Merged

fix(server): preserve root agent activity #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions FORK.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ This repository is a fork of `pingdotgg/t3code`. Keep this file focused on fork

- Parent timelines keep subagent commands, file changes, tool calls, web searches, image views, and diffs.
- Subagent messages, reasoning, goals, plans, token usage, and thread/turn state stay out of the parent timeline. Codex child relationships are recognized from both `collabAgentToolCall` and `subAgentActivity` items.
- Root-agent activity remains visible. Filtering applies only to provider thread IDs explicitly discovered through those child relationship items.

### Provider Launch Environment

Expand Down
9 changes: 1 addition & 8 deletions apps/server/src/provider/Layers/CodexSessionRuntime.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -876,21 +876,14 @@ export const makeCodexSessionRuntime = (
const payload = notification.params;
const route = readRouteFields(notification);
const providerThreadId = readNotificationThreadId(notification);
const rootProviderThreadId = yield* currentSessionProviderThreadId;
const childThreadTurns = yield* Ref.get(childThreadTurnsRef);
const childParentTurnId =
providerThreadId === undefined ? undefined : childThreadTurns.get(providerThreadId);
const parentTurnId = childParentTurnId ?? route.turnId;

rememberChildThreadTurns(childThreadTurns, notification, parentTurnId);

const belongsToChild =
childParentTurnId !== undefined ||
(providerThreadId !== undefined &&
rootProviderThreadId !== undefined &&
providerThreadId !== rootProviderThreadId);

if (belongsToChild && !shouldKeepChildNotification(notification)) {
if (childParentTurnId !== undefined && !shouldKeepChildNotification(notification)) {

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 30, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Add regression tests for root and child notification routing

This changes backend notification classification without adding focused coverage; the existing CodexSessionRuntime.test.ts suite does not exercise root-versus-child routing. Add cases proving that a mismatched resumed-root thread retains messages/reasoning while explicitly discovered child threads suppress conversation events but retain allowed activity, so this fix cannot silently reintroduce either regression.

AGENTS.md reference: AGENTS.md:L101-L101

Useful? React with 👍 / 👎.

yield* Ref.set(childThreadTurnsRef, childThreadTurns);
return;
}
Expand Down
Loading