Skip to content

🔧 chore(repo): drop local editor config#13

Merged
xdanger merged 2 commits intomainfrom
xdanger-codex/remove-editor-config
Apr 2, 2026
Merged

🔧 chore(repo): drop local editor config#13
xdanger merged 2 commits intomainfrom
xdanger-codex/remove-editor-config

Conversation

@xdanger
Copy link
Copy Markdown
Member

@xdanger xdanger commented Apr 2, 2026

Summary

Remove committed local editor and devcontainer files from the repository.

Why

These files describe machine-specific workspace setup and are not needed for shared project history.

Impact

Developers will keep personal VS Code and devcontainer preferences locally instead of inheriting them from the repo.

Validation

No runtime checks were needed for this change.
Verified the change only deletes .vscode and .devcontainer files.

- :emoji: avoid committing machine-specific workspace setup
- :emoji: keep the repo focused on shared project files
@xdanger xdanger self-assigned this Apr 2, 2026
@xdanger xdanger marked this pull request as ready for review April 2, 2026 10:31
@xdanger xdanger requested a review from Copilot April 2, 2026 10:32
@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented Apr 2, 2026

Greptile Summary

This PR removes .vscode/ and .devcontainer/ configuration files from version control so that editor and container preferences stay local to each developer's machine. The change is purely a deletion with no runtime impact.

Confidence Score: 5/5

Safe to merge — deletions only, no runtime behavior affected.

All three deleted files are editor/devcontainer configs with zero runtime impact. The only finding is a P2 suggestion to add the directories to .gitignore to prevent accidental re-commit, which does not block merge.

No files require special attention; consider updating .gitignore as a follow-up.

Important Files Changed

Filename Overview
.devcontainer/devcontainer.json Deleted devcontainer configuration; straightforward removal with no runtime impact.
.vscode/extensions.json Deleted VS Code extension recommendations; no runtime impact.
.vscode/settings.json Deleted VS Code workspace settings (formatOnSave, linting rules, formatter assignments); no runtime impact.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[PR: Remove editor config files] --> B[Delete .devcontainer/devcontainer.json]
    A --> C[Delete .vscode/extensions.json]
    A --> D[Delete .vscode/settings.json]
    B --> E[Devs configure containers locally]
    C --> F[Devs manage extension recommendations locally]
    D --> G[Devs manage formatter/linter settings locally]
    E & F & G --> H[No shared repo-level editor config]
    H --> I{.gitignore updated?}
    I -- No --> J[⚠️ Files could be re-committed accidentally]
    I -- Yes --> K[✅ Directories permanently excluded]
Loading

Comments Outside Diff (1)

  1. .vscode/settings.json

    P2 Consider adding .vscode/ and .devcontainer/ to .gitignore

    The .gitignore currently has no entries for .vscode/ or .devcontainer/, so these directories could be inadvertently re-committed by any contributor in the future. Adding them aligns with the stated goal of keeping editor preferences purely local.

    # .gitignore addition
    .vscode/
    .devcontainer/
    

Reviews (1): Last reviewed commit: "🔧 chore(repo): drop local editor config" | Re-trigger Greptile

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes repository-committed local VS Code workspace settings and devcontainer configuration so developer-specific editor/container preferences are kept out of shared project history.

Changes:

  • Delete .vscode/settings.json
  • Delete .vscode/extensions.json
  • Delete .devcontainer/devcontainer.json

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
.vscode/settings.json Removes shared VS Code workspace settings from the repo.
.vscode/extensions.json Removes shared VS Code extension recommendations from the repo.
.devcontainer/devcontainer.json Removes the committed devcontainer setup/configuration.
Comments suppressed due to low confidence (1)

.vscode/settings.json:1

  • If the intent is to keep .vscode/ and .devcontainer/ purely local going forward, consider adding both paths to .gitignore (or otherwise enforcing it). Without ignore rules, developers will keep seeing these directories as untracked and they can be accidentally re-committed in future PRs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions github-actions Bot requested a review from Copilot April 2, 2026 10:35
@xdanger xdanger review requested due to automatic review settings April 2, 2026 10:35
- :emoji: let review jobs use the public Anthropic API when no override is configured
- :emoji: keep repository variable support for custom gateways
@github-actions github-actions Bot requested a review from Copilot April 2, 2026 10:46
@xdanger xdanger review requested due to automatic review settings April 2, 2026 10:46
@xdanger xdanger merged commit 45b7e32 into main Apr 2, 2026
3 of 4 checks passed
@xdanger xdanger deleted the xdanger-codex/remove-editor-config branch April 2, 2026 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants