chore: update to latest changes in tangle #367
Merged
Merged
Conversation
Contributor
Author
drewstone
approved these changes
Oct 22, 2024
drewstone
left a comment
Contributor
There was a problem hiding this comment.
Fix the comment, this looks good.
shekohex
commented
Oct 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes several updates across multiple files, focusing on dependency updates, code refactoring, and metadata extraction improvements. The most important changes include upgrading dependencies, refactoring hooks and job extraction logic, and introducing new metadata extraction functions.
Mainly, the new changes we are introducing in the tangle-network/tangle#794 removes the notion of separate hooks and instead unifies everything in one filed called
managerin the Service Blueprint. This field will be set to the EVM Smart contract that manages the lifecycle of a the blueprint instances.No more
#[job(verifier(evm = "IncredibleSquaringBlueprint"))]on top of each job. This manager has aonJobResultandonJobCallhooks where you can do your normal validation and verification if you want. (by default they are no_op)Dependency Updates:
Cargo.toml: Updatedtangle-subxtdependency from version0.3.0to0.4.0.blueprint-metadata/Cargo.toml: Addedserdeas a workspace dependency.Code Refactoring:
blueprint-metadata/src/lib.rs: Refactored imports to includecargo_metadataand rearranged existing ones.blueprint-metadata/src/lib.rs: Replacedgenerate_gadgetfunction withextract_metadataandextract_blueprint_managerfunctions for better modularity.blueprint-metadata/src/lib.rs: RemovedServiceRegistrationHookandServiceRequestHookfrom theHookenum and related logic. [1] [2]Metadata Extraction:
blueprint-metadata/src/lib.rs: Introducedextract_metadataandextract_blueprint_managerfunctions to handle metadata extraction from the package.blueprints/incredible-squaring/Cargo.toml: Added blueprint manager metadata.Submodule Updates:
blueprints/incredible-squaring/contracts/lib/forge-std: Updated submodule commit reference.blueprints/incredible-squaring/contracts/lib/tnt-core: Updated submodule commit reference.