feat(personify): connect the dormant analyst→steer wire + registryScopeAnalyst#284
Merged
Conversation
…peAnalyst Thread an optional ScopeAnalyst<D> through ShapeContext / RunPersonifiedOptions / createShapeContext, and consult it at the two combinator steer gates (loopUntil.until, widen.gate.decide) instead of the hardcoded empty findings array. The analyst spawns into the SAME scope (createScopeAnalyst), so its compute stays on the conserved budget pool — equal-k holds by construction. Absent an analyst the gates keep the dormant [] default (no behavior change). Add registryScopeAnalyst: a ScopeAnalyst backed by an AnalystRegistryLike that merges N analyst kinds into one findings list and pipes them through the same assertTraceDerivedFindings firewall createScopeAnalyst uses (single-sourced selector≠judge). The ScopeAnalyzeInput→registry-inputs projection is caller-supplied (buildInputs), not an invented bridge.
tangletools
approved these changes
Jun 14, 2026
tangletools
left a comment
tangletools
left a comment
Contributor
There was a problem hiding this comment.
✅ Auto-approved PR — 5b6321ab
Blanket team auto-approval is enabled for this reviewer service.
The full PR reviewer audit still runs separately and will publish findings if it detects issues.
tangletools · auto-approval · reason: blanket_auto_approve · 2026-06-14T00:49:45Z
drewstone
added a commit
that referenced
this pull request
Jun 14, 2026
- feat(conversation): runPersonaConversation + runPersonaDispatch — the persona loop runner; any AgentProfile evaluated as a multi-round conversation, drops into runProfileMatrix as dispatch (#282) - feat(personify): connect the dormant analyst→steer wire + registryScopeAnalyst (#284) - feat(skills): build-with-agent-runtime canonical spine (#285) - fix(tool-loop): strict-model tool-call history (#286) - docs: canonical-api.md API reference (#283)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connects the analyst→steer seam that was wired to a hardcoded empty array (
loopUntilcalledspec.until(state, []),widencalledspec.gate.decide(s, [], …);createScopeAnalysthad zero live callers).ShapeContext.analyst?+RunPersonifiedOptions.analyst?(threaded viacreateShapeContext/runPersonified).loopUntil/widen:const findings = ctx.analyst ? await ctx.analyst.analyze({task, settledSoFar, nodeId: scope.view.root}) : []→ fed to the gate (was[]). Dormant[]default preserved (no behavior change without an analyst).registryScopeAnalyst(registry, buildInputs)— the panel-of-analysts adapter: merges N analyst KINDS via the existingAnalystRegistry.run, routed through the existingassertTraceDerivedFindingsfirewall (single-sourced). NOTpanel()(that's judges-vs-artifact).createScopeAnalyst), conserved-pool-charged.flatWidenGatedefault never widens so the wire is exact, and the hazard is in the docstring (not papered over).+7 tests (876 pass total), tsc + Biome clean. The shared prerequisite for the remaining analyst features (online intra-turn, long-range) + the intelligence-SDK hookup.