React 15.5 migration - #74
Merged
Merged
Conversation
|
@adriantoine The latest npm version of |
Contributor
Author
|
Indeed, I don't know why I've put Thanks I'll update! |
|
Yes please! This warning is driving me crazy. |
|
Yes, this is bugging me as well! |
taion
reviewed
Apr 10, 2017
| "mocha": "^3.1.2", | ||
| "react": "^15.3.2", | ||
| "react-dom": "^15.3.2", | ||
| "prop-types": "~15.5.6", |
| @@ -1,16 +1,17 @@ | |||
| import React from 'react'; | |||
| import PropTypes from 'prop-types'; | |||
Contributor
Author
|
@taion thanks for the review, I've updated the PR. |
taion
reviewed
Apr 10, 2017
| "peerDependencies": { | ||
| "history": "^2.0.0 || ^3.0.0", | ||
| "react": "^0.14.0 || ^15.0.0", | ||
| "prop-types": "^15.0.0", |
Owner
There was a problem hiding this comment.
this doesn't need to be a peer dep i don't think?
Contributor
Author
There was a problem hiding this comment.
I wasn't sure where to put it, If it's not a peer, should it be in the normal dependencies?
Contributor
Author
There was a problem hiding this comment.
Ok, I'll update it
Contributor
Author
|
@taion I've updated the PR. |
Owner
|
Thanks! |
Contributor
Author
|
No problem, thanks for merging! |
|
Thats for the fast update! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migration to React 15.5, see https://facebook.github.io/react/blog/2017/04/07/react-v15.5.0.html.
I've just changed the code to load PropTypes from the
prop-typespackage instead of thereactone, that removes the deprecation warning.