Conversation
commit: |
IzumiSy
force-pushed
the
add_primitive_components
branch
2 times, most recently
from
b8d40a4 to
f361611
Compare
Contributor
Author
|
/review |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
Author
|
/review |
IzumiSy
force-pushed
the
add_primitive_components
branch
from
18cfb1c to
1fdf03c
Compare
Contributor
Author
|
/review |
Contributor
Author
|
/review |
Aligns with other multi-part components (Dialog.Root, Tabs.Root, etc.): - Radio.Root / Radio.Group - Checkbox.Root / Checkbox.Group - Toggle.Root / Toggle.Group Also removes Skeleton from docs (component was deleted).
Expose an `error` field in UseAsyncItemsReturn so consumers can distinguish network failures from empty result sets. The error is set in the catch block and reset on successful fetch or empty input.
Rename `query` to `value` in AutocompleteUseAsyncReturn to match the Root component's `value` prop, enabling ergonomic spread usage. Also propagate the new `error` field from useAsyncItems.
Define and export ButtonProps type from button.tsx, re-export from index.ts to follow the minimal export pattern (ComponentName + ComponentNameProps).
IzumiSy
force-pushed
the
add_primitive_components
branch
from
d069858 to
ba544cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a comprehensive set of pre-styled primitive UI components to
@tailor-platform/app-shell, giving consumers a complete toolkit for building ERP interfaces without additional UI library dependencies.New Components (25)
Updated Components
data-slotattributes and namespace object pattern (e.g.Dialog.Root,Dialog.Content)Hooks
Combobox.useCreatable— on-the-fly item creation with sync/async/deferred patternsCombobox.useAsync/Autocomplete.useAsync— debounced async fetching with abort supportCombobox.useFilter/Autocomplete.useFilter— client-side filtering (re-exported from Base UI)Other Changes
index.tsexports into logical sections (Core, Module/Resource, Auth, Hooks, Routing, UI Components)docs/components.md— comprehensive documentation for all 39 UI componentsdocs/api.mdinto the new fileCLAUDE.mddocumentation indexuseCreatable), NumberField, Popover, Radio, Select, Slider, Switch, Tabs, Toggle