Restructure excel_ui.run() to process Excel files lacking Beads or Samples sheets. - #339
Closed
JS3xton wants to merge 3 commits into
Closed
Restructure excel_ui.run() to process Excel files lacking Beads or Samples sheets.#339JS3xton wants to merge 3 commits into
JS3xton wants to merge 3 commits into
Conversation
Contributor
Author
|
Closes #215. |
Restructured excel_ui.run() to make processing of different Excel sheets more modular.
Contributor
Author
|
Closing to move from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing
I created the following variants of
examples/experiment.xlsx:experiment_nobeads.xlsx(Units changed from MEF to RFI)experiment_nosamples.xlsxexperiment_nobeads_nosamples.xlsxand ran the Excel UI (
>python -m FlowCal.excel_ui -i experiment*.xlsx -v -p), and the output files (XLSX file and plots) were created as expected in bothPython 3.8 + Anaconda 2020.02andPython 2.7 + Anaconda 5.2.0.Running the Excel UI with
develop(3affd34) threw errors related to the absence of the Excel sheets.