Merged
Conversation
t8y8
approved these changes
Apr 25, 2018
Collaborator
t8y8
left a comment
t8y8
left a comment
There was a problem hiding this comment.
🚀 after a small change.
The . method will run over pytest code or other eggs installed as part of dev dependancies
docs/dev-guide.md
Outdated
| - Only touch the minimal amount of files possible while still accomplishing the goal. | ||
| - Only touch the fewest number of files possible while still accomplishing the goal. | ||
| - Ensure all indentation is done as 4-spaces and your editor is set to unix line endings. | ||
| - The code matches PEP8 style guides. If you cloned the repo you can run `pycodestyle .` |
Collaborator
There was a problem hiding this comment.
pycodestyle server-client-python test samples
Contributor
Author
There was a problem hiding this comment.
OK. I think you mean instead of "The code matches PEP8 style guides. If you cloned the repo you can run pycodestyle ."
We should change this to:
The code matches PEP8 style guides. If you cloned the repo you can run pycodestyle server-client-python test samples
Added Tyler's correction for pycodestyle.
Contributor
Author
|
Made Tyler's change. Squashing and merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR points developers to the gh-pages branch for making doc updates.