Merged
Conversation
Contributor
jacalata
commented
Sep 20, 2022
jacalata
commented
- cleaned up the client version
- made it available to the calling program and actually in the headers
- Added a smoke test action for monitoring what's on PyPi, and a sample smoke test to help people debug
| - name: Launch app | ||
| run: | | ||
| python -c "import tableauserverclient as TSC | ||
| server = TSC.Server('Fake-Server-Url', use_server_version=False)" |
There was a problem hiding this comment.
For my understanding, how does this look when it fails?
Contributor
Author
There was a problem hiding this comment.
I'm not certain, because sometimes the github environment does something differently to what I expect. But it should check the exit code of the call to python: if any exceptions are thrown that will be something different to 0, and will be called a failed step.
nikhillakshman
approved these changes
Sep 22, 2022
FOSSA got confused by the versioneer license file being in the root.
jacalata
force-pushed
the
jac/smoke-tests
branch
from
27870fc to
9eafccb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.